Installer impressionWHY DOES YOUR BOOT SCREEN TAKE 15 SECONDS OF SLEEP! HOLY CRAP MAN I DONT WANNA WAIT 15 SECONDS EACH BOOT WTF IS WRONG WITH YA.
I mean seriously, first time I've seen someone take 15 seconds. Just wow … make it like 2 seconds or something. Thats ridiculous.
Gonna edit that out real quick and then continue review.
After install impressionWell, the installer drops me to the shell, doesn't reboot.
Update? Sure, dropped back to shell.
Well it always says there is an update.
Skipping it says No such program. and puts me to shell.
Line 89 of boot reads: "if fs.exists("/archilyos/system/0.7v") then"
Shouldn't that be "if fs.exists("/archily/system/0.7v") then" I saw this file but not archillyos.
Changing that, just realized there is no "/archily/system/gui"
Looking back in the installer, you forgot to make all the directories first, THEN placing files in them, so ill just make all those dirs i see and then reinstall.
After installed impression.So reinstalled, all the files are there now.
Well, Went to rename the icon on my desktop, it didn't erase the name entirely.
And pressed enter got:
gui:173: attempt to index ? (a nil value)
Dropped me to shell. No crash handler? No wrapping in pcall?
So renaming is broken … nice.
What is CH-Icon? CHeck icon? CHange icon? CiH virus?
It brings up a prompt, so it must be Change icon?
Typing something in gets me
gui:190: attempt to index ? (a nil value)
Again, dropped to shell. Nice to know I'm being protected by this OS's security.
Used Re-Link, what does this do? I'm guessing its what the icon points to.
Same thing as CH-Icon and rename, got an error:
gui:207: attempt to index ? (a nil value)
And once again crashed to shell.
Alright, time to see if clicking on the desktop does anything. Nope, just opens FileManager and Internet.
Wait … what Internet icon? And I can't make any icons? Just change exising ones? (broken)
I also see npaintpro in the applications, where is this launchable from?
You also have applications in two different locations, "archily/system/programs" and "archily/system"
Well, decided to run the File Manager, i've seen this FM before, so I closed it.
Screen is just blank? I have to click on it so it comes back?
Time to test the [SYSTEM] bar, ahh good ol taco editor!
Same thing, screen goes blank when i exit program, so its not just a FM issue, its a program running issue.
The lua prompt shows that you don't reset colors or even move the terminal to the top OR clear the terminal. Which can have negative effects on CraftOS programs.
And the About program does nothing, just says "No such program."
Well … thats everything in the os.
File review!Nothing uses kernel.co, it just gets loaded but nothing from it is referenced.
What is .background, its just the color white … and spaces … on something that was already white.
It doesn't even span the entire desktop …
Code review!Well, after taking a first glance of the code, I can say not much effort was put into this.
None of the code is formatted, there are no returns, nothing is local.
The updater has a hard coded pastebin link, unless this is changed by your account, this updates nothing.
Infact, the updater will never run, since it checks if there is a 0.7v file. There always will be (once the installer is fixed)
It seems the desktop icons and background are fixed, as the gui puts uses hard coded values for placement.
Also, what is this background? When i commented out the code for the background, the desktop looks the same.
After review!That wasn't too pleasing. That startup time is WAAY too long. There isn't much content at the moment.
The code has obviously not been tested, there is a random unused file.
Absolutly no security at all, doesn't even catch its crashes, thats extremly easy to write. its just one function and a pcall.
Security: 0/10
Productivity: 1/10
Graphics: 8/10
Internal working: 1/10