Inventory Compaction!

shiphorns, on 28 February 2013 - 05:28 AM said:

You might have been searching for the wrong key words. What your script is doing is not what people in computer science most commonly describe as 'sorting', because your program does not make an effort to put stacks of like items into adjacent slots. Your code preserves relative ordering. So, you could end up with a full stack of cobble in slot 1, then some gravel in slot 2, then more cobble in slot 3… which is not what people typically consider 'sorted'. You can't see this in your Youtube examples, only because you don't have more than 64 of any particular item.

What you're doing would be more accurately described as inventory compaction, or consolidation. You're consolidating to a minimum number of stacks, to get the most free inventory slots.

happydude11209, on 29 March 2013 - 07:33 PM said:

pastebin link is broken

Engineer, on 30 March 2013 - 12:40 AM said:

Thats unfortunate. I seem to have lost that code also :/

function sortInv()
  for i = 1, 16 do
	if turtle.getItemSpace(i) > 0 then
	  turtle.select(i)
	  for j = i, 16 do
		if turtle.compareTo(j) then
		  turtle.transferTo(i, turtle.getItemCount(j))
		end
	  end
	end
  end
end

TheOriginalBIT, on 30 March 2013 - 01:10 AM said:

Engineer, on 30 March 2013 - 12:40 AM said:

Thats unfortunate. I seem to have lost that code also :/

I'm assuming it would just be something along these lines?

Spoiler

function sortInv()
  for i = 1, 16 do
	if turtle.getItemSpace(i) > 0 then
	  turtle.select(i)
	  for j = i, 16 do
		if turtle.compareTo(j) then
		  turtle.transferTo(i, turtle.getItemCount(j))
		end
	  end
	end
  end
end

happydude11209, on 31 March 2013 - 09:44 PM said:

:/ darn

TheOriginalBIT, on 30 March 2013 - 01:10 AM said:

Engineer, on 30 March 2013 - 12:40 AM said:

Thats unfortunate. I seem to have lost that code also :/

I'm assuming it would just be something along these lines?

Spoiler

function sortInv()
  for i = 1, 16 do
	if turtle.getItemSpace(i) > 0 then
	  turtle.select(i)
	  for j = i, 16 do
		if turtle.compareTo(j) then
		  turtle.transferTo(i, turtle.getItemCount(j))
		end
	  end
	end
  end
end

function sortInv()
  for i = 1, 16 do
	if turtle.getItemSpace(i) > 0 then
	  turtle.select(i)
	  for j = i, 16 do
		if turtle.compareTo(j) then
		  turtle.select(j)
		  turtle.transferTo(i, turtle.getItemCount(j))
		  turtle.select(i)
		end
	  end
	end
  end
end

happydude11209, on 31 March 2013 - 10:09 PM said:

your code's a bit off, I added two lines to make it work

turtle.select(i)

theoriginalbit, on 31 March 2013 - 10:27 PM said:

happydude11209, on 31 March 2013 - 10:09 PM said:

your code's a bit off, I added two lines to make it work

you can remove the

turtle.select(i)

after transferring… the code I wrote will do the select(i) I had just forgotten the select(j). I wrote it in ~5 seconds should have proof read it first :P/> thanks. good pickup.

happydude11209, on 31 March 2013 - 10:50 PM said:

You're welcome :)/> thanks for telling me about select(i) I hope you don't mind that I used your function in my version of the program :)/>

happydude11209, on 31 March 2013 - 11:05 PM said:

After removing that second turtle.select(i) I run in to some issues with multiple stacks of the same type of block, when I run it it compacts the first stack but since it's still inside the for j = i,16 loop it hasn't done turtle.select(i) and it does the rest of the comparisons to the empty slot that was just created. It seems that that second turtle.select(i) is needed.

Engineer, on 31 March 2013 - 11:29 PM said:

Edit: Found original code, added to OP

theoriginalbit, on 01 April 2013 - 12:13 AM said:

Now make it sort. so similar items are grouped together as well :P/>

happydude11209, on 01 April 2013 - 01:41 PM said:

I have an idea about how to get the program to work when it is more than half full, but it needs at least one open slot, and it will take a complete rewrite of my sorting phase :(/> I will make a new post once it is done.

theoriginalbit, on 01 April 2013 - 03:49 PM said:

happydude11209, on 01 April 2013 - 01:41 PM said:

I have an idea about how to get the program to work when it is more than half full, but it needs at least one open slot, and it will take a complete rewrite of my sorting phase :(/> I will make a new post once it is done.

Use turtle.dropUp() so that it drops onto itself (incase its over a hole or lava) then sort and use suck. granted the last item wont be sorted, but its harder with a full inv.

happydude11209, on 01 April 2013 - 05:10 PM said:

What if it's under lava? But I do like that Idea :)/>

happydude11209, on 01 April 2013 - 09:08 PM said:

I think I got it, there are still some random bugs to iron out but I can kill them in the morning when my mind is refreshed. Pastebin for the full inventory sorter http://pastebin.com/62YBW1y1. I've speed it up and it works up until the final steps, I will have to look tomorrow for where it is getting stuck in an infinite loop with the test inventory I was using (three stacks of each log type and a stack of each leaf type in random order, sometimes froze when sorting).

theoriginalbit, on 01 April 2013 - 09:10 PM said:

happydude11209, on 01 April 2013 - 09:08 PM said:

I think I got it, there are still some random bugs to iron out but I can kill them in the morning when my mind is refreshed. Pastebin for the full inventory sorter http://pastebin.com/62YBW1y1. I've speed it up and it works up until the final steps, I will have to look tomorrow for where it is getting stuck in an infinite loop with the test inventory I was using (three stacks of each log type and a stack of each leaf type in random order, sometimes froze when sorting).

Maybe Engineer can have a look and try fix it while you're asleep…

sortsMade = 0
while sortsMade <= 16 do
turtle.select(16)
openSlot = getNextUnsorted()
turtle.transferTo(openSlot, turtle.getItemCount(16))
slotsFinished[openSlot] = true
cleanInv(16, getNextUnsorted(), -1)
sortsMade = sortsMade + 1
for checkSlot = 16, openSlot, -1 do -- THIS IS THE FOR I WAS TALKING ABOUT
if checkSlot == (getNextUnsorted()) then
break
end
turtle.select(openSlot)
if turtle.compareTo(checkSlot) then
turtle.select(checkSlot)
while turtle.getItemCount(checkSlot) > 0 do
moveSlot = openSlot + 1
while not turtle.transferTo(moveSlot, turtle.getItemCount(checkSlot)) do
moveSlot = moveSlot + 1
end
end
slotsFinished[moveSlot] = true
cleanInv(checkSlot, getNextUnsorted(), -1)
sortsMade = sortsMade + 1
checkSlot = 16
end
end

punchin, on 03 April 2013 - 12:32 AM said:

About halfway through the thread (before you added sorting), I decided to take a stab at this. About an hour later, I was finished. Continued the thread and found out you had added sorting already. Downloaded yours and took a look at it. It's shorter than mine by 27 lines, but mine was a lot faster. I did find a part in yours that I found sped mine up a bit, too. Your line 3 where you check to see if there is anything in the slot before you check to see if anything stacks with it was genius. It added 2 lines to mine, but cut up to about 30 seconds off if the inventory is small.

Here's what I came up with: http://pastebin.com/AqukeQKf

Tested it with the following inventory randomized: 2 stacks of coal, 2.5 stacks of redwood logs, 2.75 stacks of bonemeal, and 2 stacks of redwood saplings.

Ran it through several times and it sorted it right each time.

local function space()
    print("Checking for available space")

    s = 0

    for i=1,16 do
        if turtle.getItemCount(i) == 0 then
            s = 1
            l = i-1
            break
        end
    end
    -- vSpace()
    if s == 1 then
        print("Verified space")
        return
    else
        print("Not enough space. Please clear at least 1 slot and press enter")
        read()
        space()
    end
end