This is a read-only snapshot of the ComputerCraft forums, taken in April 2020.
StrangeGamerHD's profile picture

Xeon OS

Started by StrangeGamerHD, 11 April 2016 - 05:34 PM
StrangeGamerHD #1
Posted 11 April 2016 - 07:34 PM


NOTE: This is just an Preview Installer and will be changed in the Future !

Xeon OS -
My new OS


It has lots of functions making Computers in Minecraft easier to use !
It has an Windows 10 Style Desktop Design and is very easy to use !

Most of the planned Functions are not ready yet - it´s an Beta

Functions:
-Searchbar (This is very useful :D/>)
-Version Check at startup (You´ll not even see it :3)
-Very good Design ! (Looks like the Win 10 Desktop , the Login Screen is beautiful :D/>)
-Every User has its own Profile Picture - yay :D/>
-Very easy switch to CraftOS
-Anti Terminate Protection
-Your Passwords are Save (Thanks to sha256 encryption)
-Infinite Users !!!

Planned:
-Appstore
-Usable Desktop
-Time and Date
-Changeable Backgrounds
-Data Manager
-"All Apps" Button
-"Last App"

Current version:
0.4B

Changes 0.3B: (Thanks to TNT_Nolan :D/>)
No slow text in installer
Fix crash on orange favourite colour
It says you if your password is false
Completely new Installer

Changes 0.4B: (Thanks to Nothy , Blue , Jiloacom :D/>)
sha256
some language stuff
Searchbar gives not found output
New Logo


The Current Version can always be downloaded per:
pastebin run zY24cE2L
Edited on 22 April 2016 - 12:05 PM
TNT_Nolan #2
Posted 13 April 2016 - 12:23 AM
Ok, I am going to rate your os. I liked the start-up screen with the animated pictures but It looked like that you copied the user CrazedProgrammer. When I was setting up my account I really thought that the slow text was unnecessary. If you don't do the password right it does not tell you, it just makes another "Please set a password". I really think the fake wait times are annoying to like saving data. I like the make a profile picture though. If you choose the orange favorite color the program will crash. I think that the operating system is very interesting and cool. I would rate this around a 6.5/10 of the interface.

Now the code! Ok, your startup consists of 100 drawing functions, just make a for loop and never start counting from negative numbers.


frames = 1
number_of_frames = 10
while number_of_frames ~= frames do
      term.clear()
      paintutils.drawImage(Xeon,18,frames)
      sleep(0.1)
      frames = frames + 1 
end

Your folders are a bit unorganized if you ask me. You should have different folders like Xeon/Users/Config and Xeon/Users/Paint instead of cramming it in to one directory. Program sorting is fine. 8/10 for the coding.
Edited on 12 April 2016 - 10:41 PM
Nothy #3
Posted 18 April 2016 - 01:52 PM
Here's some feedback:

The OS itself is good, but it needs more work.
The search feature seems to break every once in a while, same thing with the Last app thing.
7/10 would use in the future.
Blue #4
Posted 18 April 2016 - 03:37 PM
I like it,although there's a few things that you could improve:
- "necessary" is spelled incorrectly in the installer
- The installation is a little bit long. Choosing the avatar and colors should be optional and the continue buttons aren't necessary since you can't modify the input.
- Black text on a light-blue background doesn't look very nice
- Menu looks disorganized
Spoiler
The login screen looks a bit like Glass UI,but that's ok :P/>


-Your Passwords are Save :3 (Thanks to MD5 encryption)
MD5 is insecure,use SHA-256 or SHA-512 instead.

How is the app store going to work? If you want to make a "real" app store like Oeed and DannySMC try learning some PHP.

Also,you should add a logo to your post,maybe something like this:
Spoiler
Edited on 18 April 2016 - 01:49 PM
Saldor010 #5
Posted 18 April 2016 - 03:42 PM
I notice that on line 5 (of the installer), you use shell.run to get a pastebin file:

shell.run("pastebin get 2wxQPtuv Xeon/System/installationbackground")
Yet on line 11, you define a function to retrieve pastebin files. Why can't you just define that function earlier, use it on line 5 and be consistent with your code?

Then on line 19 you define this continue button function:

local function continuebutton()
term.setTextColor(colors.black)
term.setBackgroundColor(colors.white)
term.setCursorPos(35,15)
print("Continue")
local event, button, x, y = os.pullEvent("mouse_click")
if y == 15 and x < 43 and x > 34 and button == 1 then
continued = 1
end
end
Which then uses ugly global variables to inform the program that it has been clicked. It also doesn't appear to work if you click something other than the button the first time, forcing you to do something like this:

while true do
continuebutton()
if continued == 1 then
continued = 0
....
While if you would just write your code better, you could do something like this:

local function continuebutton()
term.setTextColor(colors.black)
term.setBackgroundColor(colors.white)
term.setCursorPos(35,15)
print("Continue")
while true do
local event, button, x, y = os.pullEvent("mouse_click")
if y == 15 and x < 43 and x > 34 and button == 1 then
return true
end
end
end
....
continuebutton()
-- Note the lack of any control statements or loops, it's already handled for us by the function.
-- And this function could still be a lot better.
....

I have to go, but there seems to be a lot of inconsistencies and bad coding in general just in the installer. I hope for your sake there isn't as much in the actual operating system, or it will really come back to bite you when you try to update and change your code some day.

UPDATE: Took a quick look at your startup file. Lines 5-31 and 43-83 really need to be shortened to a for loop. You also seem to have confused the period and the comma halfway through writing out lines 43-83 manually, which looks like it could cause an error (can't test it right now though). You wouldn't have silly mistakes like this in your code if you used a loop instead of manually writing everything out.

UPDATE 2: Don't even get me started on the system file, almost everything in there is hard coded and impossible to change without rewriting the code or making ugly changes to it. You seriously need to go learn more and get more familiar with Lua and learning how to modularize your programs before you make an operating system.
Edited on 18 April 2016 - 02:20 PM
TNT_Nolan #6
Posted 19 April 2016 - 04:26 PM
Hey, thanks for doing my updates! Can you add some of my apps in there?

Thanks,
Nolan
DannySMc #7
Posted 19 April 2016 - 05:02 PM
If you really want; you could use my App Store in your OS? That would be awesome. I love the name, the OS could do with a lot of updates, to make it more functional, but good start. I would suggest adding a custom file manager, with copy and paste functionality.
Edited on 19 April 2016 - 03:35 PM