Another one of my beginning programs. Again, I am open to suggestions on how to make my programs better, or just hints on how to be a better programmer overall.
term.clear()
term.setCursorPos(1,1)
io.write("What is your name?n")
name = io.read()
if name == "Name" then
print("Welcome, Name. What is the password?")
password = io.read()
if password == "Password" then
print("Access granted! You may now use this computer.")
else
print("Access denied!")
end
else
print("Access denied!")
end
That very good for a first login program. Here is some things you should consider.
* Use local variables. Ex:
local x = 2
instead of just
x = 2
* Since it is a login script, you might want to change
io.read()
to
io.read("*")
. This will change every character the user inputs into a '*', which means other people (on SMP) won't be able to read what you are typing. However the function will still return what the user typed in (not the '*'s).
* You can use 'write()' and 'read()' instead of 'io.write()' and 'io.read()'. It just makes it shorter, not much difference really.
* From what I can see, the program exits to shell after you put in a password (either wrong or right). To avoid this, use a while loop. Ex:
while true do
term.clear()
term.setCursorPos(1,1)
io.write("What is your name?n")
name = io.read()
if name == "Name" then
print("Welcome, Name. What is the password?")
password = io.read()
if password == "Password" then
print("Access granted! You may now use this computer.")
break
else
print("Access denied!")
end
else
print("Access denied!")
end
end
. This will run the code again unless the password was correct. 'break' escapes out of the loop.
* As your program is right now, the user can still CTRL+T out of your program. There is a way to prevent this. I'll let you search for that.
That's all I can offer, hope you take this advice into consideration.
