What's wrong?

--[[ Cobble Turtle ]]--

local mined = 0
local amount = false

function dropItems()
    turtle.turnRight()
    turtle.turnRight()
    print("Dropping Items...")
    for i = 1, 16 do
        turtle.select(i)
        turtle.drop()
    end
    turtle.select(1)
    print("Dropped!")
    turtle.turnRight()
    turtle.turnRight()
end

write("Amount of cobblestone: ")
repeat
        amount = tonumber(read())
        if not amount then
                write("I need a number: ")
        end
until amount

print("Amount set to " .. tostring(amount))

repeat
        if turtle.dig() then
         print("Mined!")
                mined = mined + 1
        end
        sleep(0.2)
        local full = true
for i = 1, 16 do
    full = (turtle.getItemSpace(i) == 0) and full
end
if full then
    print("Inventory is full!")
    dropItems()
end
until amount == mined
print("Successfully mined "..mined.." cobblestone!")
    dropItems()

D3matt, on 14 May 2013 - 08:32 AM said:

3rd line. Cobble needs to be cobble. lua is case sensitive.

print("Amount set to "..input)

inf = 1
input = 200  //here
else
for a = 1,input do
  turtle.select(1)
  if turtle.compare() then
   turtle.dig()
   print("Mined!")
   cobble = cobble + 1
   if inf == 1 then
 input=200  //here
   end

makerimages, on 14 May 2013 - 09:11 AM said:

Whats exactly wrong now?


and also, why set input twice?

inf = 1
input = 200  //here
else
for a = 1,input do
  turtle.select(1)
  if turtle.compare() then
   turtle.dig()
   print("Mined!")
   cobble = cobble + 1
   if inf == 1 then
input=200  //here
   end

makerimages, on 14 May 2013 - 09:16 AM said:

look at the commented lines

--[[ Cobble Turtle ]]--

inf = 0
Cobble = 0

write("How much cobblestone you want: ")
local input = read()
print("Amount set to "..input)
if input == "-1" then
print("infinite!")
inf = 1
input = 200
else
for a = 1,input do
turtle.select(1)
if turtle.compare() then
turtle.dig()
print("Mined!")
cobble = Cobble + 1
sleep(1.5)
if inf == 1 then
input = 200
end
end
end
print("Successfully mined "..cobble.." cobblestone!")
end

Spongy141, on 14 May 2013 - 10:21 AM said:

Try indenting (Wont make your code better, just looks better, and easier to read…. but cobble needs to be Cobble… if your trying to have it add from its previous value, you can not have it change its variable…

LBPHacker, on 14 May 2013 - 10:32 AM said:

Okay… Big chages coming…

Spoiler

--[[ Cobble Turtle ]]--

-- * Cleaned up a bit and commented

local mined = 0
local amount = false

-- * read amount again and again until we get a real number
write("How much cobblestone you want: ")
repeat
	amount = tonumber(read())
	-- * let the user know that we need a number
	if not amount then
		write("Seriously: ")
	end
until amount

-- * verify the amount
print("Amount set to " .. tostring(amount))

repeat
	-- * turtle.dig returns false if no block was dug
	--   so we won't increase mined if that's the case
	-- * actually no need of turtle.compare here - I assume
	--   nothing will spawn in front of the turtle apart
	--   apart from cobblestone
	-- * by the way, turtle.compare would mess up things
	--   if there was no cobble in slot 1
	if turtle.dig() then
		mined = mined + 1
	end
	sleep(0.2)
until amount == mined

Ask if something is not clear.

tonkku107, on 14 May 2013 - 10:34 AM said:

sleep 1.5 is the minium without "crashing" the program

LBPHacker, on 14 May 2013 - 10:37 AM said:

tonkku107, on 14 May 2013 - 10:34 AM said:

sleep 1.5 is the minium without "crashing" the program

Nope. Since sleep yields the coroutine of the computer, you won't get "too long without yielding" even with a sleep(0).

tonkku107, on 14 May 2013 - 10:39 AM said:

How about the -1 (Turtle will keep mining until inventory is full / terminated)

--[[ Cobble Turtle ]]--

-- * Cleaned up a bit and commented

local mined = 0
local amount = false

-- * read amount again and again until we get a real number
write("How much cobblestone you want: ")
repeat
    amount = tonumber(read())
    -- * let the user know that we need a number
    if not amount then
        write("Seriously: ")
    else
        if amount < 1 then
            write("Maybe something larger than 0: ")
            -- * I set amount to false here on purpose
            amount = false
        end
    end
until amount

-- * verify the amount
print("Amount set to " .. tostring(amount))

repeat
    -- * turtle.dig returns false if no block was dug
    --   so we won't increase mined if that's the case
    -- * actually no need of turtle.compare here - I assume
    --   nothing will spawn in front of the turtle apart
    --   apart from cobblestone
    -- * by the way, turtle.compare would mess up things
    --   if there was no cobble in slot 1
    if turtle.dig() then
        mined = mined + 1
    end
    sleep(0.2)
until amount == mined

LBPHacker, on 14 May 2013 - 10:42 AM said:

tonkku107, on 14 May 2013 - 10:39 AM said:

How about the -1 (Turtle will keep mining until inventory is full / terminated)

Oh I knew I forgot something…
New code:

Spoiler

--[[ Cobble Turtle ]]--

-- * Cleaned up a bit and commented

local mined = 0
local amount = false

-- * read amount again and again until we get a real number
write("How much cobblestone you want: ")
repeat
	amount = tonumber(read())
	-- * let the user know that we need a number
	if not amount then
		write("Seriously: ")
	else
		if amount < 1 then
			write("Maybe something larger than 0: ")
			-- * I set amount to false here on purpose
			amount = false
		end
	end
until amount

-- * verify the amount
print("Amount set to " .. tostring(amount))

repeat
	-- * turtle.dig returns false if no block was dug
	--   so we won't increase mined if that's the case
	-- * actually no need of turtle.compare here - I assume
	--   nothing will spawn in front of the turtle apart
	--   apart from cobblestone
	-- * by the way, turtle.compare would mess up things
	--   if there was no cobble in slot 1
	if turtle.dig() then
		mined = mined + 1
	end
	sleep(0.2)
until amount == mined

LBPHacker, on 14 May 2013 - 10:48 AM said:

Oh! Just realized that you want it to mine infinitely if the given amount is -1! Hold on…

LBPHacker, on 15 May 2013 - 10:45 AM said:

O'course. Make the turtle face towards the chest, select the proper slot, and turtle.drop().

local full = true
for i = 1, 16 do
    full = (turtle.getItemSpace(i) == 0) and full
end
-- full is now true if there is literally no more space in the inventory
if full then
    dropItems() -- this is a function I'm gonna explain later
end

LBPHacker, on 15 May 2013 - 11:01 AM said:

Option 1: Check the modulo of mined. When mined % 1024 is 0, the inventory sure is full. Keep in mind that if the user is a noob, he can put things into the turtle's inventory - this solution can't predict that. (1024; 16 slots multiplied by 64 cobblestones in a stack)
Option 2: (Not sure how much time would it take) Check turtle.getItemSpace after every mined cobblestone. Like:

local full = true
for i = 1, 16 do
	full = (turtle.getItemSpace(i) == 0) and full
end
-- full is now true if there is literally no more space in the inventory
if full then
	dropItems() -- this is a function I'm gonna explain later
end

So yeah… dropItems()… Where is the chest? Next to the turtle?

local full = true
for i = 1, 16 do
	full = (turtle.getItemSpace(i) == 0) and full
end
if full then
	turtle.right()
	turtle.right()
	dropItems()
	turtle.right()
	turtle.right()
end

function dropItems()
    turtle.turnRight()
    turtle.turnRight()
    for i = 1, 16 do
        turtle.select(i)
        turtle.drop()
    end
    turtle.turnRight()
    turtle.turnRight()
end

LBPHacker, on 15 May 2013 - 11:43 AM said:

Of course it's nil. I said I'll explain it later, but couldn't do that without knowing where the chest is.

function dropItems()
    turtle.turnRight()
    turtle.turnRight()
    for i = 1, 16 do
        turtle.select(i)
        turtle.drop()
    end
    turtle.turnRight()
    turtle.turnRight()
end