Help with making a stone button run a program

 if rs.getInput(side) then shell.run("extend") end 

jay5476, on 07 August 2013 - 02:02 AM said:

im guessing it is just a normal redstone signal so you could use

 if rs.getInput(side) then shell.run("extend") end 

assuming your using extend to make the bridge

while true do -- repeat forever

  -- as long as the redstone signal is off, wait for a redstone signal to change.
  -- os.pullEvent doesn't return which signal changed, that's why we need to use rs.getInput to see if the
  -- signal is on yet - we don't want to run the program if an unrelated redstone signal changed.
  -- by waiting for a redstone signal change with os.pullEvent, instead of using sleep, we reduce server load.
  while not rs.getInput("input side") do
    os.pullEvent("redstone")
  end

  -- run the other program
  shell.run("Extend")
end

--Make it run forever
while true do

repeat
  os.pullEvent("redstone")
until rs.getInput("side") --Wait until redstone input is true

-- Text and apperances
term.clear()
term.setCursorPos(1, 1)
print("Extending the Bridge!")
sleep "1.5"
term.clear()
term.setCursorPos(1, 1)

--Extending bridge 6 blocks using White as the extender wire
for i=1, 6 do
redstone.setBundledOutput("back", 1)
sleep "0.6"
redstone.setBundledOutput("back", 0)
sleep "0.6"
end

-- Some more text
print("The Bridge has been Extended!")

-- 6 seconds to get over
sleep "6"

term.clear()
term.setCursorPos(1, 1)

-- Pulling the bridge back
for i=1, 6 do
redstone.setBundledOutput("back", 2)
sleep "0.6"
redstone.setBundledOutput("back", 0)
sleep "0.6"
end

end --While end

sleep "0.6"   --# wrong
sleep(0.6)    --# right

Kingdaro, on 07 August 2013 - 03:16 PM said:

A part of me wonders why nobody pointed out that the OP is using strings for sleep instead of numbers.

sleep "0.6"   --# wrong
sleep(0.6)	--# right

jay5476, on 07 August 2013 - 02:02 AM said:

im guessing it is just a normal redstone signal so you could use

 if rs.getInput(side) then shell.run("extend") end 

assuming your using extend to make the bridge

Kingdaro, on 07 August 2013 - 03:16 PM said:

A part of me wonders why nobody pointed out that the OP is using strings for sleep instead of numbers.

 sleep "0.6" --# wrong sleep(0.6) --# right 

civilwargeeky, on 07 August 2013 - 01:45 PM said:

Hi. I added a few things to your code to make it better (hopefully). First off, instead of saying the same thing over and over again, you can use a "for" loop. You can see how I used them to shorten and simplify the code substantially. You can find examples here: http://www.computerc...info/wiki/Loops. The "while true do" at the top makes it run as long as the computer is turned on. The repeat loop I used (which is what actually solves your problem) will do whatever is inside first (wait for a change in redstone), and then evaluate the condition at the end. If the condition is true, then the loop will end, and go on to the rest of your code. Hope that helps :)/>/>/>

 --Make it run forever while true do repeat os.pullEvent("redstone") until rs.getInput("side") --Wait until redstone input is true -- Text and apperances term.clear() term.setCursorPos(1, 1) print("Extending the Bridge!") sleep "1.5" term.clear() term.setCursorPos(1, 1) --Extending bridge 6 blocks using White as the extender wire for i=1, 6 do redstone.setBundledOutput("back", 1) sleep "0.6" redstone.setBundledOutput("back", 0) sleep "0.6" end -- Some more text print("The Bridge has been Extended!") -- 6 seconds to get over sleep "6" term.clear() term.setCursorPos(1, 1) -- Pulling the bridge back for i=1, 6 do redstone.setBundledOutput("back", 2) sleep "0.6" redstone.setBundledOutput("back", 0) sleep "0.6" end end --While end 

Kegulf, on 07 August 2013 - 10:23 PM said:

civilwargeeky, on 07 August 2013 - 01:45 PM said:

Hi. I added a few things to your code to make it better (hopefully). First off, instead of saying the same thing over and over again, you can use a "for" loop. You can see how I used them to shorten and simplify the code substantially. You can find examples here: http://www.computerc...info/wiki/Loops. The "while true do" at the top makes it run as long as the computer is turned on. The repeat loop I used (which is what actually solves your problem) will do whatever is inside first (wait for a change in redstone), and then evaluate the condition at the end. If the condition is true, then the loop will end, and go on to the rest of your code. Hope that helps :)/>/>/>

 --Make it run forever while true do repeat os.pullEvent("redstone") until rs.getInput("side") --Wait until redstone input is true -- Text and apperances term.clear() term.setCursorPos(1, 1) print("Extending the Bridge!") sleep "1.5" term.clear() term.setCursorPos(1, 1) --Extending bridge 6 blocks using White as the extender wire for i=1, 6 do redstone.setBundledOutput("back", 1) sleep "0.6" redstone.setBundledOutput("back", 0) sleep "0.6" end -- Some more text print("The Bridge has been Extended!") -- 6 seconds to get over sleep "6" term.clear() term.setCursorPos(1, 1) -- Pulling the bridge back for i=1, 6 do redstone.setBundledOutput("back", 2) sleep "0.6" redstone.setBundledOutput("back", 0) sleep "0.6" end end --While end 

Haha Yeah, as I said, I just started in CC :P/> Thanks, looks awesome :D/>
One problem :o/> Doesn't work, wrote it as you have done here.
Tried to run it, got:
bios:206:[string "extend"]:6: 'end' expected (to close 'while' at line 2)
tried to put in end after the first section, did not work :P/>

civilwargeeky, on 08 August 2013 - 02:48 AM said:

Kegulf, on 07 August 2013 - 10:23 PM said:

Haha Yeah, as I said, I just started in CC :P/> Thanks, looks awesome :D/>
One problem :o/> Doesn't work, wrote it as you have done here.
Tried to run it, got:
bios:206:[string "extend"]:6: 'end' expected (to close 'while' at line 2)
tried to put in end after the first section, did not work :P/>

Hmm. That's odd. Notepad++ says all the blocks are properly closed. Visual inspection confirms… Are you sure you put an "end" after both the "for" blocks? Did you add any if statements that might need "end"s? I'm pretty sure the problem is not on my end.