Peripheral issue

Will this work to wrap peripherals?
I'm getting "peripheral :20: expected string"

local PeriList = peripheral.getNames()
local TankList = {}
local OtherPeriList = {}
local MonList = {}
local o = 1
local u = 1
local m = 1
for i = 1, #PeriList do
if PeriList == "rcirontankvalvetile" then
TankList = PeriList
u = u + 1
elseif PeriList == "monitor" then
MonList[m] = PeriList
m = m + 1
else
OtherPeriList[o] = PeriList
o = o + 1
end
end
local Tank1 = peripheral.wrap(TankList[1])
local Tank2 = peripheral.wrap(TankList[2])
local Tank3 = peripheral.wrap(TankList[3])
local Tank4 = peripheral.wrap(TankList[4])
local Mon = peripheral.wrap(MonList[1])

Quick tip, when using "#" on an empty table, it returns 0, so you can use this and a plus 1 to add to the table automatically as it get's bigger, instead of having a specific variable for that.

for i = 1, #PeriList do
  if PeriList[i] == "rcirontankvalvetile" then
	TankList[#TankList+1] = PeriList[i]
  elseif PeriList[i] == "monitor" then
	MonList[#MonList+1] = PeriList[i]
  else
	OtherPeriList[#OtherPeriList+1] = PeriList[i]
  end
end

Also, you could just wrap the peripheral to an index in your table directly, instead of storing the name in a table, then wrapping that name to a variable.

Now as for the actual issue, since you haven't specified how this is all connected im going to assume it's through a wired modem. This means the names won't be exactly rcirontankvalvetile, which it would need to be for your if condition to be fulfilled. Chances are it's something like 0_rcirontankvalvetile, depending on how many you have connected. To deal with this, we can use string.match() instead of the double equal sign.

if string.match(PeriList[i],"rcirontankvalvetile") then

Basically what this does is, if the first string passed contains the second string passed, it will return the second string. There is a LOT more you can do with this funciton, but it's not nessacary to deal with your issue.

CometWolf, on 05 March 2014 - 07:10 PM said:

Quick tip, when using "#" on an empty table, it returns 0, so you can use this and a plus 1 to add to the table automatically as it get's bigger, instead of having a specific variable for that.

for i = 1, #PeriList do
  if PeriList[i] == "rcirontankvalvetile" then
	TankList[#TankList+1] = PeriList[i]
  elseif PeriList[i] == "monitor" then
	MonList[#MonList+1] = PeriList[i]
  else
	OtherPeriList[#OtherPeriList+1] = PeriList[i]
  end
end

Now as for the actual issue, since you haven't specified how this is all connected im going to assume it's through a wired modem. This means the names won't be exactly rcirontankvalvetile, which it would need to be for your if condition to be fulfilled. Chances are it's something like 0_rcirontankvalvetile, depending on how many you have connected. To deal with this, we can use string.match() instead of the double equal sign.

if string.match(PeriList[i],"rcirontankvalvetile") then

Basically what this does is, if the first string passed contains the second string passed, it will return the second string. There is a LOT more you can do with this funciton, but it's not nessacary to deal with your issue.

Thanks a bunch I swear you have written more of this program than me :P/>

Another Quick issue

This code skips to the else how would I test if a tank is empty?

if not tank1["name"] == nul then
steAmPI.FluPrinter(tank1)
else
Mon.setCursorPos(X1Pos, Y1Pos)
Mon.setTextColor(128)
Mon.write(" Empty ")
Mon.setCursorPos(X1Pos, Y1BarPos)
Mon.setBackgroundColor(128)
Mon.write(" ")
Mon.setBackgroundColor(32768)
end

if not tank1["name"] == nul then

Im going to assume that "nul" here is supposed to be "nil", which means you could just write this instead

if tank1["name"] then

This will equate to true aslong as the variable tank1.name is not nil or false.

Anyways, isn't there a function you have to call on the tank to actually get it's liquid contents? Assuming you didn't already do this in a piece of the code that isn't posted ofcourse.

CometWolf, on 05 March 2014 - 07:41 PM said:

if not tank1["name"] == nul then

Im going to assume that "nul" here is supposed to be "nil", which means you could just write this instead

if tank1["name"] then

This will equate to true aslong as the variable tank1.name is not nil or false.

Anyways, isn't there a function you have to call on the tank to actually get it's liquid contents? Assuming you didn't already do this in a piece of the code that isn't posted ofcourse.

yeah tank1 is a table

So… you're wrapping the tank functions to the variable tank1

local Tank1 = peripheral.wrap(TankList[1])

Then overwriting the tank functions with the tank info? Sounds like a bad idea… I mean it works, but you'll have to get the tank functions again to refresh it.

tank1 = tank1.getTankInfo()

would be better to just skip the wrap altogether.

tank1 = peripheral.call(TankList[1],"getTankInfo","unkown")

CometWolf, on 05 March 2014 - 08:14 PM said:

So… you're wrapping the tank functions to the variable tank1

local Tank1 = peripheral.wrap(TankList[1])

Then overwriting the tank functions with the tank info? Sounds like a bad idea… I mean it works, but you'll have to get the tank functions again to refresh it.

tank1 = tank1.getTankInfo()

would be better to just skip the wrap altogether.

tank1 = peripheral.call(TankList[1],"getTankInfo","unkown")

I am planing to rewrite the whole getting tank info bit soonish once I get everything else (nearly) working