Noob question for a door locking system

function command()
    ...
end

while true do
    if command == true then
        command()
    else
        sensor()
    end
end

local command_enabled = true

...

while true do
    if command_enabled then
        command()
    else
        sensor()
    end
end

TheOddByte, on 15 June 2014 - 10:57 PM said:

Ok first of all, what error are you getting?
And your indention seems kinda messed up :P/> ( But that may be the boards fault )

And you can't have the same name for a variable and a function.

function command()
	...
end

while true do
	if command == true then
		command()
	else
		sensor()
	end
end

But I don't see a variable called command in your code though :P/>
Try doing this

local command_enabled = true

...

while true do
	if command_enabled then
		command()
	else
		sensor()
	end
end

( The three dots indicate code :P/> )

local updateTimer = os.startTimer( 2 ) -- Start the timer for the first time

...

while true do
    local e = { os.pullEvent() }
    if e[1] == "rednet_message" then
        --[[
            Here e[1] is the event, in this case rednet_message, e[2] is the id, e[3] is the message
            and e[4] would be the distance if I got all of them in correct order
        --]]
        if e[3] == "enable_command" then -- If it recieves the message 'enable_command' it will turn the boolean 'command_enabled' to true
            command_enabled = true
        elseif e[3] == "disable_command" then
            command_enabled = false -- Added this just incase you want to turn of command
            updateTimer = os.startTimer( 2 ) -- Start the timer again since we disabled command
        end

    elseif e[1] == "timer" then
        if e[2] == updateTimer then
            updateTimer = os.startTimer( 2 ) -- Restart the timer
        end
    end

    if command_enabled then
        command()
    else
        sensor()
    end
end

pingwel, on 17 June 2014 - 02:27 PM said:

i have added the code you made there and i kinda understand what it should do and how its done. but it dosnt return to sensor after command_enabled have been set to false

local e = { os.pullEvent() }
for i, v in ipairs( e ) do
    print( i .. ": " .. v )
end

...

1: rednet_message
2: <id>
3: <message received>
4: <distance>

TheOddByte, on 17 June 2014 - 02:54 PM said:

pingwel, on 17 June 2014 - 02:27 PM said:

i have added the code you made there and i kinda understand what it should do and how its done. but it dosnt return to sensor after command_enabled have been set to false

Try doing this as a debug in the event part

local e = { os.pullEvent() }
for i, v in ipairs( e ) do
	print( i .. ": " .. v )
end

...

to check if I put the indexes correct for the rednet part :P/>
If it was correct it would kinda print this out

1: rednet_message
2: <id>
3: <message received>
4: <distance>

pingwel, on 17 June 2014 - 04:55 PM said:

when i give a command it only outputs (1: redstone) and nothing else

rednet.send( "<ID of computer with teh code above>", "Test message, should show up in index 3" )

--[[
    Changes to script:
        *Changed variables and functions to local, it's uneccessary 
        for them to be global unless you plan on accessing them in
        another script.

        *Removed the command function and put the code into the event part

        *Removed the sleep call
--]]

local m = peripheral.wrap("left")
local command_enabled = true;
local updateTimer = os.startTimer( 2 )
rednet.open( "back" )



local function sensor()
    print("sensing")
    local names = m.getPlayerNames()
    if names[1] == nil then
        redstone.setOutput("right", true)
    else 
        rs.redstone.setOutput( "right", false ) -- I don't know why you set the output to false repeateadly, it's better todo it right before the loop
        for i = 1, #names do
            -- Removed the sleep here since that clears the event que and stops the timer
            print(names[i])
        end
    end
end

while true do
    local e = { os.pullEvent() }
    if e[1] == "rednet_message" then

        --# Check if it's an enable or disable message
        if e[3] == "enable_command" then
            command_enabled = true;
        elseif e[3] == "disable_command" then
            command_enabled = false;
        end

        --# Handle command if it's enabled
        if command_enabled then
            if e[3] == "lockdown on" then
                print( e[3] )
                rs.redstone.setOutput( "right", true )
            elseif e[3] == "lockdown off" then
                print( e[3] )
                rs.redstone.setOutput( "right", false )
            end
        end

    elseif e[1] == "timer" then
        if e[2] == updateTimer then
            updateTimer = os.startTimer( 2 )
            --# Use the sensor here instead if the command is not enabled
            if not command_enabled then
                sensor()
            end
        end
    end
end

TheOddByte, on 17 June 2014 - 07:08 PM said:

pingwel, on 17 June 2014 - 04:55 PM said:

when i give a command it only outputs (1: redstone) and nothing else

Try sending a message to the computer with this code without changing the redstone input, for example

rednet.send( "<ID of computer with teh code above>", "Test message, should show up in index 3" )

if it shows 1: redstone it means that the redstone input has changed http://www.computerc...Redstone_(event)
go and check out os.pullEvent on the wiki to get a better understanding of it > http://www.computerc...ki/Os.pullEvent

pingwel, on 17 June 2014 - 07:15 PM said:

TheOddByte, on 17 June 2014 - 07:08 PM said:

pingwel, on 17 June 2014 - 04:55 PM said:

when i give a command it only outputs (1: redstone) and nothing else

Try sending a message to the computer with this code without changing the redstone input, for example

rednet.send( "<ID of computer with teh code above>", "Test message, should show up in index 3" )

if it shows 1: redstone it means that the redstone input has changed http://www.computerc...Redstone_(event)
go and check out os.pullEvent on the wiki to get a better understanding of it > http://www.computerc...ki/Os.pullEvent

okay i did the new rednet.send command and now it says:
1: timer
2: 0
1: timer
2: 1

pingwel, on 17 June 2014 - 07:53 PM said:

Yes i have the modem on both computers xD but im just really new at this so im not 100% sure what to do when and what the diffrend stuff are completly :/
so in some way i need some training/help with learning it :)/>