TE Energy Cell storage and usage monitoring system - issues

local ec = {}
local maxStore, curStore, storePercent, curUsed, lastStore = 0
local energyGained = true

function comma_value(n) -- credit http://richard.warburton.it
	local left,num,right = string.match(n,'^([^%d]*%d)(%d*)(.-)$')
	return left..(num:reverse():gsub('(%d%d%d)','%1,'):reverse())..right
end

function calcEnergyUsage()
	if lastStore == nil then
		lastStore = 1
	end
	
	curUsed = (curStore - lastStore)/100
	
	if curUsed < 0 then
		energyGained = false
	elseif curUsed > 0 then
		energyGained = true
	end
	
	curUsed = math.abs(curUsed)
end

while true do
	maxStore = 0
	curStore = 0
	storePercent = 0
	curUsed = 0
	
	for a,b in pairs(peripheral.getNames()) do
		if peripheral.getType(B)/>/>/> == "cofh_thermalexpansion_energycell" then
			ec[#ec+1] = peripheral.wrap(B)/>/>/>
			curStore = curStore + ec[#ec].getEnergyStored("")
			maxStore = maxStore + ec[#ec].getMaxEnergyStored("")
		end
		
		if peripheral.getType(B)/>/>/> == "monitor" then
			m = peripheral.wrap(B)/>/>/>
			term.redirect(m)
		end
	end
	storePercent = curStore/maxStore*100

	term.clear()
	term.setCursorPos(1, 1)
	
	local percentColour = 0
	
	if tonumber(storePercent) < 30 then
		percentColour = 16384
	elseif tonumber(storePercent) < 50 and tonumber(storePercent) > 30 then
		percentColour = 2
	elseif tonumber(storePercent) < 70 and tonumber(storePercent) > 50 then
		percentColour = 16
	elseif tonumber(storePercent) < 90 and tonumber(storePercent) > 70 then
		percentColour = 32
	elseif tonumber(storePercent) > 90 then
		percentColour = 2048
	end
	
	m.setTextScale(4)
	term.setTextColour(colors.white)
	print("Main Power Storage:	")
	
	term.setTextColour(percentColour)
	term.write(comma_value(curStore))
	term.setTextColour(colors.white)
	print(" RF of				")
	
	term.setTextColour(percentColour)
	term.write(comma_value(maxStore))
	term.setTextColour(colors.white)
	print(" RF				 ")
	
	term.setTextColour(percentColour)
	term.write(math.floor(storePercent).."%	")
	
	calcEnergyUsage()
	if lastStore ~= 0 then
		if energyGained == true then
			term.setTextColour(colors.lime)
		else
			term.setTextColour(colors.red)
		end
		term.write(comma_value(tostring(curUsed)))
		term.setTextColour(colors.white)
		print(" RF/t		   ")
	end
	lastStore = curStore
	
	sleep(5)
end

xBlizzDevious, on 26 October 2014 - 02:29 AM said:

3. Timing… I had "sleep(2)" before but it always seemed a little longer than two seconds. Thinking that it must be the system slowing by iterating through 126 peripherals every 2 seconds, I changed it to 5 seconds. Now it seems nearer to 13 seconds to me. Is this a bug, my bad coding or something else?

while true do
  --#define variables
  local id = os.startTimer( 5 ) --#set a timer to go off in five seconds
  --#do rest of code
  while true do --#infinate loop
    local _, tid = os.pullEvent( "timer" ) --#wait for the timer to go off
    if id == tid then --#if the timer went off
      break --#end the loop
    end
  end
end

KingofGamesYami, on 26 October 2014 - 03:32 AM said:

xBlizzDevious, on 26 October 2014 - 02:29 AM said:

3. Timing… I had "sleep(2)" before but it always seemed a little longer than two seconds. Thinking that it must be the system slowing by iterating through 126 peripherals every 2 seconds, I changed it to 5 seconds. Now it seems nearer to 13 seconds to me. Is this a bug, my bad coding or something else?

This isn't a bug, and its not your coding either. The method getEnergyStored queues an event, and then waits for it, thus inciting a small lag factor. I've heard running the methods in parallel can speed it up, but I'm not sure.

There are three improvements I can see being made here

1 - use parallel
2 - use peripheral.call instead of wrapping, since you don't keep the wrapped object
3 - manually implement sleep for better timing (this allows the sleep time to ignore whatever time it took to call the methods)

Example of 3:

while true do
  --#define variables
  local id = os.startTimer( 5 ) --#set a timer to go off in five seconds
  --#do rest of code
  while true do --#infinate loop
	local _, tid = os.pullEvent( "timer" ) --#wait for the timer to go off
	if id == tid then --#if the timer went off
	  break --#end the loop
	end
  end
end

for a,b in pairs(peripheral.getNames()) do
		if peripheral.getType(B)/>/>/>/>/>/> == "cofh_thermalexpansion_energycell" then
			ec[#ec+1] = peripheral.wrap(B)/>/>/>/>/>/>
			curStore = curStore + ec[#ec].getEnergyStored("")
			maxStore = maxStore + ec[#ec].getMaxEnergyStored("")
		end
		
		if peripheral.getType(B)/>/>/>/>/>/> == "monitor" then
			m = peripheral.wrap(B)/>/>/>/>/>/>
			term.redirect(m)
		end
	end

	for a,b in pairs(peripheral.getNames()) do
		if peripheral.getType(B)/>/>/> == "cofh_thermalexpansion_energycell" then
			parallel.waitForAll(
			peripheral.call(b, curStore = curStore + b.getEnergyStored(""),
			peripheral.call(b, maxStore = maxStore + b.getMaxEnergyStored(""))
		end
		
		if peripheral.getType(B)/> == "monitor" then
		    term.redirect(B)/>
		end
	end

xBlizzDevious, on 26 October 2014 - 03:44 AM said:

-snip-
So if I change this function:

for a,b in pairs(peripheral.getNames()) do
        if peripheral.getType(B)/> == "cofh_thermalexpansion_energycell" then
            ec[#ec+1] = peripheral.wrap(B)/>
            curStore = curStore + ec[#ec].getEnergyStored("")
            maxStore = maxStore + ec[#ec].getMaxEnergyStored("")
        end

        if peripheral.getType(B)/> == "monitor" then
            m = peripheral.wrap(B)/>
            term.redirect(m)
        end
    end

to:

    for a,b in pairs(peripheral.getNames()) do
        if peripheral.getType(B)/> == "cofh_thermalexpansion_energycell" then
            parallel.waitForAll(curStore = curStore + b.getEnergyStored("")
            parallel.waitForAll(maxStore = maxStore + b.getMaxEnergyStored("")
        end

        if peripheral.getType(B)/> == "monitor" then
            m = peripheral.wrap(B)/>
            term.redirect(m)
        end
    end

And simply swap my "sleep(5)" line for your above code (and probably change the 5 in the timer to a 2 or 3)?

And do you know the answers to my other questions (4 and 5)?

    local toRun = {} --#define a table
    for _,b in ipairs(peripheral.getNames()) do --#change to ipairs, eliminate a
        if peripheral.getType(B)/> == "cofh_thermalexpansion_energycell" then
            toRun[#toRun+1] = function() curStore = curStore + peripheral.call( b, "getEnergyStored", "" ) end --#change to peripheral.call, add new function to toRun
            toRun[#tRun+1] = function() maxStore = maxStore + peripheral.call( b, "getMaxEnergyStored", "") end --#same as above
        elseif peripheral.getType(B)/> == "monitor" then --#remove end, add elseif
            m = peripheral.wrap(B)/>
            term.redirect(m)
        end
    end
    parallel.waitForAll( unpack( toRun ) ) --#run contents of the table parallel to each other

KingofGamesYami, on 26 October 2014 - 03:52 AM said:

	for a,b in pairs(peripheral.getNames()) do
		if peripheral.getType( B ) == "cofh_thermalexpansion_energycell" then

if peripheral.getType( b ) == "cofh_thermalexpansion_energycell" then

Dragon53535, on 26 October 2014 - 03:58 AM said:

Problem with your code Yami

KingofGamesYami, on 26 October 2014 - 03:52 AM said:

	for a,b in pairs(peripheral.getNames()) do
		if peripheral.getType( B ) == "cofh_thermalexpansion_energycell" then

Should be

if peripheral.getType( b ) == "cofh_thermalexpansion_energycell" then

Darn you forums, nevermind, carry on.

Edit: There i fixed it, add spaces! MWAHAHAHAHA

xBlizzDevious, on 26 October 2014 - 04:03 AM said:

-snip-
So I don't need the for loop? How's it going to iterate across 125 of them, then?

xBlizzDevious, on 26 October 2014 - 02:29 AM said:

5. Finally, in what ways could I optimise my program to a) run more efficiently and b ) for the code to look nicer and be easier to read? I like how easy it is now, but I constantly see code written by pros that's just so much "fancier" than anything I can write.

        if curUsed < 0 then
                energyGained = false
        elseif curUsed > 0 then
                energyGained = true
        end

        energyGained = curUsed > 0

        if tonumber(storePercent) < 30 then
                percentColour = 16384
        elseif tonumber(storePercent) < 50 and tonumber(storePercent) > 30 then
                percentColour = 2
        elseif tonumber(storePercent) < 70 and tonumber(storePercent) > 50 then
                percentColour = 16
        elseif tonumber(storePercent) < 90 and tonumber(storePercent) > 70 then
                percentColour = 32
        elseif tonumber(storePercent) > 90 then
                percentColour = 2048
        end

        if storePercent < 30 then
                percentColour = 16384
        elseif storePercent < 50 then  -- We already know it's more than 30 by this point...
                percentColour = 2
        elseif storePercent < 70 then
                percentColour = 16
        elseif storePercent < 90 then
                percentColour = 32
        else
                percentColour = 2048
        end

                if energyGained == true then
                        term.setTextColour(colors.lime)
                else
                        term.setTextColour(colors.red)
                end

                term.setTextColour(energyGained and colors.lime or colors.red)

Bomb Bloke, on 26 October 2014 - 05:19 AM said:

Spoiler

The B)/>/>/> is presumably triggered by one of the extensions installed here (like the one which bugs out the search), given that I haven't seen it occur on other Invision boards. If you disable emoticons in your post you can avoid it.

The html thing can be "fixed" by mashing the rich-text editor toggle over and over quickly.

xBlizzDevious, on 26 October 2014 - 02:29 AM said:

5. Finally, in what ways could I optimise my program to a) run more efficiently and b ) for the code to look nicer and be easier to read? I like how easy it is now, but I constantly see code written by pros that's just so much "fancier" than anything I can write.

Since you're asking for nitpicks, I suppose I'll nitpick. :P/>

In regards to your formatting: It really doesn't matter; go with what you find easiest to read. As it stands, you're formatting things nearly exactly the way I do (proper indentation with line breaks spacing out blocks of code), so personally I think that's great.

I'd ditch the calcEnergyUsage() function and move its contents down into the main "while" loop. Since you only call that code from one place, there's no benefit in having it bundled into a function at all - it slows your script down, makes it longer, and forces people trying to read it to scroll around the page.

Sometimes you might think it's a good idea to create a function just so you can "label" what a given segment of code does. If the segment is large enough (eg a couple of hundred lines), then I may do this myself on occasion. For a dozen lines of code… better just to use comments.

comma_value() is used well, but should be localised to the script.

You could set the text scale once, before your "while" loop starts, instead of setting it to the same thing over and over again inside said loop.

This check here:

		if curUsed < 0 then
				energyGained = false
		elseif curUsed > 0 then
				energyGained = true
		end

… will leave energyGained unaltered if curUsed = 0. If that's intended, then fine. If it's not, you could re-write it to just this:

		energyGained = curUsed > 0

If you decide to keep that bit as it is, then at least move the curUsed = math.abs(curUsed) line up into the "if" block. There's no point in running it unless curUsed < 0, which you just so happen to be specifically checking for anyway.

This block here:

		if tonumber(storePercent) < 30 then
				percentColour = 16384
		elseif tonumber(storePercent) < 50 and tonumber(storePercent) > 30 then
				percentColour = 2
		elseif tonumber(storePercent) < 70 and tonumber(storePercent) > 50 then
				percentColour = 16
		elseif tonumber(storePercent) < 90 and tonumber(storePercent) > 70 then
				percentColour = 32
		elseif tonumber(storePercent) > 90 then
				percentColour = 2048
		end

… will fail to do anything when storePercent is 30, 50, 70 or 90. There's also no point in the tonumber() call, given that storePercent is already a number - even if it weren't, better to convert it once and save it rather than converting it every time you want to do something with it.

Plus, some of the checks are redundant - each one you perform narrows the possibilities down, limiting the number of specific comparisons you need to make. That is to say, this'd work just fine:

		if storePercent < 30 then
				percentColour = 16384
		elseif storePercent < 50 then  -- We already know it's more than 30 by this point...
				percentColour = 2
		elseif storePercent < 70 then
				percentColour = 16
		elseif storePercent < 90 then
				percentColour = 32
		else
				percentColour = 2048
		end

Us of a ternary (and the fact that explicitly comparing energyGained to true is a redundant step) means we can shrink this:

				if energyGained == true then
						term.setTextColour(colors.lime)
				else
						term.setTextColour(colors.red)
				end

… to this:

				term.setTextColour(energyGained and colors.lime or colors.red)

    for a,b in pairs(peripheral.getNames()) do
        if peripheral.getType(B)/> == "cofh_thermalexpansion_energycell" then
            curStore = curStore + parallel.waitForAll(peripheral.call(b, getEnergyStored("")))
            maxStore = maxStore + parallel.waitForAll(peripheral.call(b, getMaxEnergyStored("")))
        end
    end

xBlizzDevious, on 26 October 2014 - 12:04 PM said:

As for the Ternary thing, I vaguely remember that from back when I was at college, but that link doesn't help me understand it at all.

xBlizzDevious, on 26 October 2014 - 12:04 PM said:

Now the thing that I can't figure out now, is how to run the getEnergyStored() and getMaxEnergyStored() functions in parallel and to fill in the variables as I need. So how would I go about that? This doesn't work (attempt to call nil) and I guess doesn't actually run in parallel either?

    local toRun = {} --#define a table
    for _,b in ipairs(peripheral.getNames()) do
        if peripheral.getType(b) == "cofh_thermalexpansion_energycell" then
            toRun[#toRun+1] = function() curStore = curStore + peripheral.call( b, "getEnergyStored", "" ) end  -- Make a function pointer, stick it in the toRun table
            toRun[#toRun+1] = function() maxStore = maxStore + peripheral.call( b, "getMaxEnergyStored", "") end
        elseif peripheral.getType(b) == "monitor" then
            m = peripheral.wrap(b)
        end
    end
    term.redirect(m)  -- Better to do this once

toRun[1] = function()
        curStore = curStore + peripheral.call( "firstcell", "getEnergyStored", "" )
end

toRun[2] = function()
        maxStore = maxStore + peripheral.call( "firstcell", "getMaxEnergyStored", "" )
end

toRun[3] = function()
        curStore = curStore + peripheral.call( "secondcell", "getEnergyStored", "" )
end

curStore, maxStore = 0, 0
parallel.waitForAll(unpack(toRun))

Bomb Bloke, on 26 October 2014 - 01:25 PM said:

Spoiler

xBlizzDevious, on 26 October 2014 - 12:04 PM said:

As for the Ternary thing, I vaguely remember that from back when I was at college, but that link doesn't help me understand it at all.

Make sure you read the expressions tutorial it links off to, especially the bit about logical operators. That same page also has a re-phrasing as to how Lua's approximation of ternarys work.

Even if you don't understand, I'm sure you can see how to use it. But don't worry too much - like I said in my disclaimer, I was just nit-picking.

xBlizzDevious, on 26 October 2014 - 12:04 PM said:

Now the thing that I can't figure out now, is how to run the getEnergyStored() and getMaxEnergyStored() functions in parallel and to fill in the variables as I need. So how would I go about that? This doesn't work (attempt to call nil) and I guess doesn't actually run in parallel either?

You're attempting to call functions called getEnergyStored and getMaxEnergyStored (which don't actually exist in order to be called - at least, not in the way you're trying to call them!), before passing the results off to perperpheral.call() (the documentation of which you should read). Then there's your misuse of parallel.waitForAll(), which doesn't return anything of value here, needs to be passed function pointers (as opposed to the results of executed functions), and isn't worth using unless you're passing it multiple function pointers at once…

Let's take another look at the code KoGY posted for you earlier:

	local toRun = {} --#define a table
	for _,b in ipairs(peripheral.getNames()) do
		if peripheral.getType(B)/>/> == "cofh_thermalexpansion_energycell" then
			toRun[#toRun+1] = function() curStore = curStore + peripheral.call( b, "getEnergyStored", "" ) end  -- Make a function pointer, stick it in the toRun table
			toRun[#toRun+1] = function() maxStore = maxStore + peripheral.call( b, "getMaxEnergyStored", "") end
		elseif peripheral.getType(B)/>/> == "monitor" then
			m = peripheral.wrap(B)/>/>
		end
	end
	term.redirect(m)  -- Better to do this once

The above block fills the toRun table with functions. The first function will read along the lines of this:

toRun[1] = function()
		curStore = curStore + peripheral.call( "firstcell", "getEnergyStored", "" )
end

The next, like this:

toRun[2] = function()
		maxStore = maxStore + peripheral.call( "firstcell", "getMaxEnergyStored", "" )
end

The next, like this:

toRun[3] = function()
		curStore = curStore + peripheral.call( "secondcell", "getEnergyStored", "" )
end

And so on.

Whenever you call one of these functions, the peripheral call they perform will pause your script while waiting for OpenPeripheral to throw a special event. The idea is that you should be able to run other functions in the toRun table while waiting for others to complete, and the parallel API provides a simple method of doing so.

Hence, whenever you want to run ALL the functions in the table at once, you just do this:

curStore, maxStore = 0, 0
parallel.waitForAll(unpack(toRun))

This takes all the function pointers in the toRun table, and passes them off to the parallel API (using unpack() - make sure to read that whole page!), which then goes and actually runs them for you - making sure that whenever one stops to wait for an event, the next function is being started to avoid wasting time.

Note that depending on the nature of these events, attempting to throw and catch lots of them at the same time like this may just cause your big pile of functions to fall into a screaming heap. I guess try it, and see what happens.

If you're still unsure about the parallel API's workings, try reading this event tutorial before looking at the parallel API docs again.

To sum up, it's a short block of code, but there's a lot of complex operations to understand within it.

local ec = {}
local maxStore, curStore, storePercent, curUsed, lastStore = 0
local energyGained = true

function comma_value(n) -- credit http://richard.warburton.it
	local left,num,right = string.match(n,'^([^%d]*%d)(%d*)(.-)$')
	return left..(num:reverse():gsub('(%d%d%d)','%1,'):reverse())..right
end
--Disabled to allow easier debugging
--[[
local m = peripheral.find("monitor")
if m then
	m.setTextScale(4)
	term.redirect(m)
end
]]--
while true do
	maxStore, curStore, storePercent, curUsed = 0
	local id = os.startTimer( 5 ) --#set a timer to go off in five seconds
	
	local toRun = {} --#define a table
	for _,b in ipairs(peripheral.getNames()) do
		if peripheral.getType(B)/>/> == "cofh_thermalexpansion_energycell" then
			toRun[#toRun+1] = function() curStore = curStore + peripheral.call(b, "getEnergyStored", "") end  -- Make a function pointer, stick it in the toRun table
			toRun[#toRun+1] = function() maxStore = maxStore + peripheral.call(b, "getMaxEnergyStored", "") end
		end
	end
	parallel.waitForAll(unpack(toRun))

	storePercent = curStore/maxStore*100

	term.clear()
	term.setCursorPos(1, 1)
	
	local percentColour = 0
	
	if storePercent < 30 then
		percentColour = 16384
	elseif storePercent < 50 then
		percentColour = 2
	elseif storePercent < 70 then
		percentColour = 16
	elseif storePercent < 90 then
		percentColour = 32
	else
		percentColour = 2048
	end
	
	term.setTextColour(colors.white)
	print("Main Power Storage:	")
	
	term.setTextColour(percentColour)
	term.write(comma_value(curStore))
	term.setTextColour(colors.white)
	print(" RF of				")
	
	term.setTextColour(percentColour)
	term.write(comma_value(maxStore))
	term.setTextColour(colors.white)
	print(" RF				 ")
	
	term.setTextColour(percentColour)
	term.write(math.floor(storePercent).."%	")
	
	if lastStore == nil then
		lastStore = 1
	end
	
	curUsed = (curStore - lastStore)/100
	
	energyUsed = curUsed > 0
	
	curUsed = math.abs(curUsed)
	
	if lastStore ~= 0 then
		term.setTextColour(energyGained and colors.lime or colors.red)
		term.write(comma_value(curUsed))
		term.setTextColour(colors.white)
		print(" RF/t		   ")
	end
	lastStore = curStore
	
	while true do --#infinite loop
		local _, tid = os.pullEvent( "timer" ) --#wait for the timer to go off
		if id == tid then --#if the timer went off
			break --#end the loop
		end
	end
end

parallel:7: vm error:
java.lang.ArrayIndexOutOfBoundsException

xBlizzDevious, on 26 October 2014 - 04:20 PM said:

-snip-
Another thing I'm curious about: in the original code, I had: "for a,b in pairs" but in the code KoGY posted, he's used: "for a,b in ipairs". What's the difference?
-snip-

KingofGamesYami, on 26 October 2014 - 05:01 PM said:

xBlizzDevious, on 26 October 2014 - 04:20 PM said:

-snip-
Another thing I'm curious about: in the original code, I had: "for a,b in pairs" but in the code KoGY posted, he's used: "for a,b in ipairs". What's the difference?
-snip-

ipairs basically means 'iterated pairs', and can only be used when a table is numerically indexed. It will iterate through the table's numeric indexes, eg [1], [2], etc. until it finds one that is nil.

pairs is used when a table doesn't have numerical indexes, or when you don't have to move in order.

In your case, it does not matter which you use, I just prefer to use ipairs when possible, thus my change.

Edit:

As to the error you posted, I'm not sure whats causing that. That error usually shows up when someone uses improper recursion, but we didn't do that here.

Bomb Bloke, on 26 October 2014 - 01:25 PM said:

Note that depending on the nature of these events, attempting to throw and catch lots of them at the same time like this may just cause your big pile of functions to fall into a screaming heap. I guess try it, and see what happens.

KingofGamesYami, on 26 October 2014 - 05:01 PM said:

As to the error you posted, I'm not sure whats causing that. That error usually shows up when someone uses improper recursion, but we didn't do that here.

Bomb Bloke, on 26 October 2014 - 09:56 PM said:

KingofGamesYami, on 26 October 2014 - 05:01 PM said:

As to the error you posted, I'm not sure whats causing that. That error usually shows up when someone uses improper recursion, but we didn't do that here.

More precisely, you get it when trying to cram more than 256 function calls into the stack at once. If there are two functions for each cell in toRun, and there are 125 cells, that's 250 calls right there. Given that bios.lua keeps a few calls floating in the stack (shell and rednet for example), that's pretty iffy just on its own, but once you add on the additional peripheral.call calls (one per toRun function) you can see that blows way past the limit.

Dividing up the functions into multiple tables (eg one for adding up curStore and one for adding up maxStore) may do the trick (you'd then use two parallel.waitForAll() calls to deal with them, halving the load on each). It may be they need to be divided up further than that.

startup:27: attempt to perform arithmetic __add on nil and number

    for _,b in ipairs(peripheral.getNames()) do
        if peripheral.getType(B)/> == "cofh_thermalexpansion_energycell" then
            current[#current+1] = function() curStore = curStore + peripheral.call(b, "getEnergyStored", "") end  --Line 27
            maxi[#maxi+1] = function() maxStore = maxStore + peripheral.call(b, "getMaxEnergyStored", "") end
        end
    end

Bomb Bloke, on 26 October 2014 - 10:24 PM said:

It's saying "nil" and "number", not "number" and "nil". Likely it's complaining that you never predefined curStore as 0.

    maxStore, curStore, storePercent, curUsed = 0

maxStore, curStore, storePercent, curUsed = 0,0,0,0

Dragon53535, on 26 October 2014 - 10:30 PM said:

maxStore, curStore, storePercent, curUsed = 0,0,0,0

You have to set the value for all, the way you have it is maxstore has a value and the rest don't

Edit: Rekt BB

Bomb Bloke, on 26 October 2014 - 10:30 PM said:

Edit: :ph34r:'d

local ec = {}
local maxStore, curStore, storePercent, curUsed, lastStore = 0
local energyGained = true

function comma_value(n) -- credit http://richard.warburton.it
	local left,num,right = string.match(n,'^([^%d]*%d)(%d*)(.-)$')
	return left..(num:reverse():gsub('(%d%d%d)','%1,'):reverse())..right
end

local m = peripheral.find("monitor")
if m then
	m.setTextScale(4)
	term.redirect(m)
end

while true do
	maxStore, curStore, storePercent, curUsed = 0, 0, 0, 0
	local id = os.startTimer( 5 ) --#set a timer to go off in five seconds
	
	local current = {} --#define a table
	local maxi = {}
	
	for _,b in ipairs(peripheral.getNames()) do
		if peripheral.getType(B)/> == "cofh_thermalexpansion_energycell" then
			current[#current+1] = function() curStore = curStore + peripheral.call(b, "getEnergyStored", "") end  --Line 27
			maxi[#maxi+1] = function() maxStore = maxStore + peripheral.call(b, "getMaxEnergyStored", "") end
		end
	end
	parallel.waitForAll(unpack(current))
	parallel.waitForAll(unpack(maxi))

	storePercent = curStore/maxStore*100

	term.clear()
	term.setCursorPos(1, 1)
	
	local percentColour = 0
	
	if storePercent < 30 then
		percentColour = 16384
	elseif storePercent < 50 then
		percentColour = 2
	elseif storePercent < 70 then
		percentColour = 16
	elseif storePercent < 90 then
		percentColour = 32
	else
		percentColour = 2048
	end
	
	term.setTextColour(colors.white)
	print("Main Power Storage:	")
	
	term.setTextColour(percentColour)
	term.write(comma_value(curStore))
	term.setTextColour(colors.white)
	print(" RF of				")
	
	term.setTextColour(percentColour)
	term.write(comma_value(maxStore))
	term.setTextColour(colors.white)
	print(" RF				 ")
	
	term.setTextColour(percentColour)
	term.write(math.floor(storePercent).."%	")
	
	if lastStore == nil then
		lastStore = 1
	end
	
	curUsed = (curStore - lastStore)/100
	
	energyUsed = curUsed > 0
	
	curUsed = math.abs(curUsed)
	
	if lastStore ~= 0 then
		term.setTextColour(energyGained and colors.lime or colors.red)
		term.write(comma_value(curUsed))
		term.setTextColour(colors.white)
		print(" RF/t		   ")
	end
	lastStore = curStore
	
	while true do --#infinite loop
		local _, tid = os.pullEvent( "timer" ) --#wait for the timer to go off
		if id == tid then --#if the timer went off
			break --#end the loop
		end
	end
end

Do I need to have the parallel function in the for loop? I thought the "unpack" thing iterated through the table itself?

KingofGamesYami, on 26 October 2014 - 10:56 PM said:

Do I need to have the parallel function in the for loop? I thought the "unpack" thing iterated through the table itself?

1. no
2. no unpack doesn't iterate through the table, it passes the contents to parallel.waitForAll, which then turns them into coroutines, starts collecting yield data and calling them in a loop until all have finished their respective tasks. I'm not sure why it'd only add up one, my first guess was you used parallel.waitForAny, which waits for only one function to be called, but your code doesn't match this theory. My second guess is only one is actually connected…

lua> textutils.pagedTabulate( peripheral.getNames() )

KingofGamesYami, on 27 October 2014 - 12:31 AM said:

Go into the lua prompt and type this:

lua> textutils.pagedTabulate( peripheral.getNames() )

current[#current+1] = function() curStore = curStore + peripheral.call(b, "getEnergyStored", "") print("curCheck: "..B)/> end

        local current = {} --#define a table
        local maxi = {}

        for _,b in ipairs(peripheral.getNames()) do
                if peripheral.getType(B)/>/> == "cofh_thermalexpansion_energycell" then
                        current[#current+1] = function() curStore = curStore + peripheral.call(b, "getEnergyStored", "") end  --Line 27
                        maxi[#maxi+1] = function() maxStore = maxStore + peripheral.call(b, "getMaxEnergyStored", "") end
                end
        end

parallel.waitForAll(unpack(maxi))

        if lastStore == nil then
                lastStore = 1
        end

        if not lastStore then lastStore = 1 end

        lastStore = lastStore or 1

        while true do --#infinite loop
                local _, tid = os.pullEvent( "timer" ) --#wait for the timer to go off
                if id == tid then --#if the timer went off
                        break --#end the loop
                end
        end

        repeat local _, tid = os.pullEvent( "timer" ) until id == tid