HELP WITH PRESSURE CONTROLLER

I have a program in computercraft to control the pressure from pneumatic craft pressure chamber . someone can tell me what's wrong?

there is pastebin link: http://pastebin.com/HYzrTpRs

What is it doing that you think is wrong and what do you want it to do instead?

When I put on the program the monitor doesn't write nothing on the screen , It writes only when preassure is higher

Try making a loop where it displays it, run it in a co-routine.

Shadow_Fade, on 07 October 2016 - 06:51 PM said:

Try making a loop where it displays it, run it in a co-routine.

A co-routine is overkill for this.

RedstonMaster - the biggest problem I'm seeing in your script is that you set presionActual only once before you start waiting for redstone events and then never check it again. I would recommend adding another check just after the redstone event check - then presionActual will be updated each loop and the program will be able to act accordingly.

...
os.pullEvent("redstone")
presionActual = p.getPressure()
...

Also, you can eliminate the peripheral wrap for the monitor within your loop - that only needs to be done once and you've already done it before the loop.

Dog, on 07 October 2016 - 07:02 PM said:

Shadow_Fade, on 07 October 2016 - 06:51 PM said:

Try making a loop where it displays it, run it in a co-routine.

A co-routine is overkill for this.

RedstonMaster - the biggest problem I'm seeing in your script is that you set presionActual only once before you start waiting for redstone events and then never check it again. I would recommend adding another check just after the redstone event check - then presionActual will be updated each loop and the program will be able to act accordingly.

...
os.pullEvent("redstone")
presionActual = p.getPressure()
...

Also, you can eliminate the peripheral wrap for the monitor within your loop - that only needs to be done once and you've already done it before the loop.

Thanks it worked

Edit:

Well it's not working now when I start the program the monitor shows the pression but it don't update the pressure

that's what I did http://pastebin.com/esLsB4W4

Are you actually toggling the redstone signal to the computer? This line here:

os.pullEvent("redstone")

… will cause it to yield until a redstone signal provided to the system either activates or de-activates.

If you are, then odds are the sleep(1) call is causing the problem - if the state change occurs while the system is sleeping, it won't be able to detect it when you later specifically stop to wait for a redstone event! You'll certainly want to remove that line.

Bomb Bloke, on 08 October 2016 - 02:33 PM said:

Are you actually toggling the redstone signal to the computer? This line here:

os.pullEvent("redstone")

… will cause it to yield until a redstone signal provided to the system either activates or de-activates.

If you are, then odds are the sleep(1) call is causing the problem - if the state change occurs while the system is sleeping, it won't be able to detect it when you later specifically stop to wait for a redstone event! You'll certainly want to remove that line.

????????????????????????????????????????????????????????

RedstonMaster, on 08 October 2016 - 10:56 PM said:

????????????????????????????????????????????????????????

That doesn't really help BombBloke understand which part of the answer you are having issues with.

In simple terms:
While the computer is sleeping, it 'eats events' due to the way sleep functions (it waits for a timer event using iteration, any events caught before that are ignored)

If your redstone state is being toggled while the computer is still sleeping, the `redstone` event fired as a result of the change will be ignored by the sleep function.

You could check if the redstone is in the desired state using `redstone.getInput` straight after the sleep call. If it is not correct, then - and only then `os.pullEvent "redstone"`. Then, if the `redstone` event was fired during the sleep, it doesn't matter because you won't be waiting for one.

It is probably best to remove the unneeded sleep as BombBloke suggested.

Hbomb_79, on 08 October 2016 - 11:07 PM said:

RedstonMaster, on 08 October 2016 - 10:56 PM said:

????????????????????????????????????????????????????????

That doesn't really help BombBloke understand which part of the answer you are having issues with.

In simple terms:
While the computer is sleeping, it 'eats events' due to the way sleep functions (it waits for a timer event using iteration, any events caught before that are ignored)

If your redstone state is being toggled while the computer is still sleeping, the `redstone` event fired as a result of the change will be ignored by the sleep function.

You could check if the redstone is in the desired state using `redstone.getInput` straight after the sleep call. If it is not correct, then - and only then `os.pullEvent "redstone"`. Then, if the `redstone` event was fired during the sleep, it doesn't matter because you won't be waiting for one.

It is probably best to remove the unneeded sleep as BombBloke suggested.

thats what I did http://pastebin.com/Bgu2N777

Did you? I still see a sleep function call in there…

Is the issue resolved?

Hbomb_79, on 09 October 2016 - 08:41 AM said:

Did you? I still see a sleep function call in there…

Is the issue resolved?

I erased the sleep function but now the monitor only shows pressure while is higher than presiónMaxima

RedstonMaster, on 09 October 2016 - 08:52 AM said:

Hbomb_79, on 09 October 2016 - 08:41 AM said:

Did you? I still see a sleep function call in there…

Is the issue resolved?

I erased the sleep function but now the monitor only shows pressure while is higher than presiónMaxima and I have the issue too long without yielding

Too long without yielding is because you have no event yielding. That means os.pullEvent or sleep functions are needed, else your program will loop forever.

What was the problem with the sleep function being used?

TOO LONG WITHOUT YIELDING

With the sleep command?

.

Hbomb_79, on 09 October 2016 - 08:57 AM said:

Too long without yielding is because you have no event yielding. That means os.pullEvent or sleep functions are needed, else your program will loop forever.

What was the problem with the sleep function being used?

I donn't know :(/>

.

Hbomb_79, on 09 October 2016 - 08:57 AM said:

Too long without yielding is because you have no event yielding. That means os.pullEvent or sleep functions are needed, else your program will loop forever.

What was the problem with the sleep function being used?

I donn't know :(/>

RedstonMaster, on 09 October 2016 - 09:10 AM said:

.

Hbomb_79, on 09 October 2016 - 08:57 AM said:

Too long without yielding is because you have no event yielding. That means os.pullEvent or sleep functions are needed, else your program will loop forever.

What was the problem with the sleep function being used?

I donn't know :(/>

.

Hbomb_79, on 09 October 2016 - 08:57 AM said:

Too long without yielding is because you have no event yielding. That means os.pullEvent or sleep functions are needed, else your program will loop forever.

What was the problem with the sleep function being used?

I donn't know :(/>

now the program doesn't work, now the screen is empty

sorry for repeating the post

What do you mean, you don't know; What is wrong with the program when the sleep command is used?

Hbomb_79, on 09 October 2016 - 09:19 AM said:

What do you mean, you don't know; What is wrong with the program when the sleep command is used?

I don't know that's I did http://pastebin.com/p6yaifwR

Hbomb_79, on 09 October 2016 - 09:19 AM said:

What do you mean, you don't know; What is wrong with the program when the sleep command is used?

It doesn't write the pressure in the monitor

It does, but you nearly immediately clear it away:

  monitor.write(presionActual)
  monitor.setCursorPos(1,1)
  monitor.clear()

Try it like:

  monitor.setCursorPos(1,1)
  monitor.clear()
  monitor.write(presionActual)

Bomb Bloke, on 09 October 2016 - 11:02 AM said:

It does, but you nearly immediately clear it away:

  monitor.write(presionActual)
  monitor.setCursorPos(1,1)
  monitor.clear()

Try it like:

  monitor.setCursorPos(1,1)
  monitor.clear()
  monitor.write(presionActual)

now the program is stopped at 0.29912 presure

RedstonMaster, on 09 October 2016 - 06:54 PM said:

Bomb Bloke, on 09 October 2016 - 11:02 AM said:

It does, but you nearly immediately clear it away:

  monitor.write(presionActual)
  monitor.setCursorPos(1,1)
  monitor.clear()

Try it like:

  monitor.setCursorPos(1,1)
  monitor.clear()
  monitor.write(presionActual)

now the program is stopped at 0.29912 presure

IT'S WORKING OHHHH YEAH IT'S WORKING :DDDDDDDDDDDD :rolleyes:/> :rolleyes:/> :rolleyes:/> :rolleyes:/> :rolleyes:THAAAAAAAAAAAAAAAAAAAAAAANKS