ComputerCraft simple program not working correctly

 
rednet.open("right")
math.randomseed(os.time())

while true do
  os.pullEvent("redstone")
  if rs.getInput("back") then
    lightid = math.random(20,29)

    if(lightid < 26) then
      idfinal = lightid
      output = "back5000"
    else
      idfinal = lightid - 5
      output = "bottom5000"
    end

    print("Output for ID: "..idfinal..") "..output)
    rednet.send(idfinal, output)
  end
end

function on(direction)
  rs.setOutput(direction, true)
end

function off(direction)
  rs.setOutput(direction, false)
end

rednet.open("top")

while true do
  print("Waiting for input...")
  id, message = rednet.receive()

  if message == "back5000" then
    on("back")
    os.sleep(5000)
    off("back")
  elseif message == "bottom5000" then
on("bottom")
    os.sleep(5000)
    off("bottom")
  else
on(message)
os.sleep(.50)
off(message)
  end

end

rednet.open(<side>)

sleep(5) -- waits 5 seconds

sleep(0.5)

"back5000"

Bomb Bloke, on 01 August 2017 - 06:42 AM said:

Code looks ok to me - how are these computers "connected"? Modems have limited range, varying according to their type and, in the case of wireless modems, world height plus weather conditions are additional factors.

Can you transmit between these systems via the Lua prompt?

Dave-ee Jones, on 01 August 2017 - 06:42 AM said:

os.clock() doesn't exist (as far as I know), try os.time().

Dave-ee Jones, on 01 August 2017 - 06:42 AM said:

The second computer never opens it's modem.

rednet.open(<side>)

Never mind.
Check to make sure the modems are on the right side. In the meantime I'll keep looking at it.
EDIT: Os.wait() doesn't exist. Use sleep(seconds). E.g.

sleep(5) -- waits 5 seconds

It does take decimals as well.

sleep(0.5)

os.clock() doesn't exist (as far as I know), try os.time().
Also, when you call "break" it exits out of the "while loop", meaning that the program stops. I'm not sure if this is what you want but if you want the loop to keep going then don't use "break".
Another thing, lower down in the script you do the "on" "off" thing again, using the message as a parameter. Think about it. If you send a message to the receiver that looks like this:

"back5000"

It's going to try and do a "rs.setOutput("back5000")" which is going to break it. Don't do that :P/>/>/>
Having ~10 computers for this seems a bit overkill..Just use 2-3 with lots of redstone coming out of each? :P/>/>/>

Bomb Bloke, on 01 August 2017 - 06:42 AM said:

Code looks ok to me - how are these computers "connected"? Modems have limited range, varying according to their type and, in the case of wireless modems, world height plus weather conditions are additional factors.
Can you transmit between these systems via the Lua prompt?

Dave-ee Jones, on 01 August 2017 - 06:42 AM said:

The second computer never opens it's modem.

rednet.open(<side>)

Never mind.
Check to make sure the modems are on the right side. In the meantime I'll keep looking at it.

EDIT: Os.wait() doesn't exist. Use sleep(seconds). E.g.

sleep(5) -- waits 5 seconds

It does take decimals as well.

sleep(0.5)

os.clock() doesn't exist (as far as I know), try os.time().

Also, when you call "break" it exits out of the "while loop", meaning that the program stops. I'm not sure if this is what you want but if you want the loop to keep going then don't use "break".

Another thing, lower down in the script you do the "on" "off" thing again, using the message as a parameter. Think about it. If you send a message to the receiver that looks like this:

"back5000"

It's going to try and do a "rs.setOutput("back5000")" which is going to break it. Don't do that :P/>

Having ~10 computers for this seems a bit overkill..Just use 2-3 with lots of redstone coming out of each? :P/>

Bomb Bloke, on 01 August 2017 - 07:14 AM said:

Sure there're plenty of other issues in the code, but they're not related to the one discussed here.

KingofGamesYami, on 01 August 2017 - 01:30 PM said:

Dave-ee Jones, on 01 August 2017 - 06:42 AM said:

os.clock() doesn't exist (as far as I know), try os.time().

It exists.

Dave-ee Jones, on 02 August 2017 - 12:44 AM said:

What version is that for? A really old one or the newest 1.8?

GrumpyCrouton, on 01 August 2017 - 01:34 PM said:

I'm using wired modem and I also have a disk drive connected at the very end via a modem and I can interact with it fine with my sending computer, so I don't think it's an issue with distance. Everything is within about 10 blocks of each other

rednet.receive()

rednet.broadcast("test")

KingofGamesYami, on 02 August 2017 - 01:27 AM said:

Dave-ee Jones, on 02 August 2017 - 12:44 AM said:

What version is that for? A really old one or the newest 1.8?

ComputerCraft 1.2 and higher. source

In fact, os.time() was added in the same version, so every version with os.time has os.clock as well.

Bomb Bloke, on 03 August 2017 - 02:33 AM said:

It may be worth double-checking your computer ID numbers. That "703" makes me doubt wonder whether any of them are within the 20-29 range.

Note that rednet doesn't use the numbers you're shown when activating / de-activating wired modems - those labels are purely for use with the peripheral API.

rednet.open("top")
rednet.host("lightControl", os.getComputerLabel())  --# Content of the second parameter doesn't really matter so long as it's unique

while true do
	print("Waiting for input...")
	local id, message = rednet.receive()

	if message == "back5000" then
		rs.setOutput("back", true)
		sleep(5) --# Sleep takes a time in seconds, 5000 = about an hour and twenty minutes
		rs.setOutput("back", false)
	elseif message == "bottom5000" then
		rs.setOutput("bottom", true)
		sleep(5)
		rs.setOutput("bottom", false)
	end
end

sleep(2) --# Give the other computers time to turn on.
rednet.open("right")

--# Gather the ids of all receiving computers into a table.
--# ids[1] = first computer id, ids[2] = second computer id, etc
local ids = {rednet.lookup("lightControl")}

while true do
	if rs.getInput("back") then
		local output = (math.random(2) == 1) and "back5000" or "bottom5000"  --# http://lua-users.org/wiki/TernaryOperator
		local idfinal = ids[math.random(#ids)]  --# Note that we're pre-"randomly"-seeded in ComputerCraft

		print("Output for ID: " .. idfinal .. ", " .. output)
		rednet.send(idfinal, output)
	end
	
	os.pullEvent("redstone")
end