[Lua][Error][Question] ComputerCraft Wiki Program

MysticT, on 23 September 2012 - 07:40 PM said:

And… what exactly you need help with?

MysticT, on 23 September 2012 - 07:45 PM said:

The usernames and passwords must be strings, so put quotes arround them, that should fix it.

TheEisbaer, on 23 September 2012 - 07:48 PM said:

MysticT, on 23 September 2012 - 07:45 PM said:

The usernames and passwords must be strings, so put quotes arround them, that should fix it.

sry i'm stupid in english are quotes this " " ??

users = { "test", "test1" }
passwords = { "test", "test1" }

MysticT, on 23 September 2012 - 07:49 PM said:

TheEisbaer, on 23 September 2012 - 07:48 PM said:

MysticT, on 23 September 2012 - 07:45 PM said:

The usernames and passwords must be strings, so put quotes arround them, that should fix it.

sry i'm stupid in english are quotes this " " ??

Yes, put them arround the usernames and passwords, like this:

users = { "test", "test1" }
passwords = { "test", "test1" }

for i,v in ipairs(users) do
  if message == v then
    valid = true
    password = passwords[i]
    break -- add break here
  else
    valid = false
  end
end

MysticT, on 23 September 2012 - 08:07 PM said:

Ok, found the error:

for i,v in ipairs(users) do
  if message == v then
	valid = true
	password = passwords[i]
	break -- add break here
  else
	valid = false
  end
end

Someone should change the code in the wiki.

MysticT, on 23 September 2012 - 08:38 PM said:

Ok, made new versions of the programs:
Server:

Spoiler

local users = { "user1" = "password1", "user2" = "password2" }
local senders = { 4, 5 }

local function clear()
	term.clear()
	term.setCursorPos(1, 1)
end

local function connect()
	for _,s in ipairs(rs.getSides()) do
		if peripheral.isPresent(s) and peripheral.getType(s) == "modem" then
			rednet.open(s)
			return true
		end
	end
	return false
end

local function isValid(sender)
	for _,id in ipairs(senders) do
		if id == sender then
			return true
		end
	end
	return false
end

if not connect() then
	print("No modem found")
	return
end

clear()
print("This is a password server. There is no user interaction here.")
print("Please find a computer and login there.")

while true do
	local id, msg = rednet.receive()
	if isValid(id) then
		local usr = textutils.unserialize(msg)
		if usr then
			if users[usr.username] == usr.password then
				rednet.send(id, "PASS_OK")
			else
				rednet.send(id, "PASS_WRONG")
			end
		end
	end
end

Client:

Spoiler

local password_server = 3

local function clear()
	term.clear()
	term.setCursorPos(1, 1)
end

local function connect()
	for _,s in ipairs(rs.getSides()) do
		if peripheral.isPresent(s) and peripheral.getType(s) == "modem" then
			rednet.open(s)
			return true
		end
	end
	return false
end

local function validateUsr(usr, timeout)
	rednet.send(password_server, textutils.serialize(usr))
	local t0 = os.clock()
	while os.clock() - t0 < timeout do
		local id, msg = rednet.receive(timeout - (os.clock() - t0))
		if id and msg then
			if id == password_server then
				if msg == "PASS_OK" then
					return true
				else
					print("Not authorised")
					sleep(1)
					return false
				end
			end
		else
			print("Server not responding")
			print("Try again")
			sleep(1)
			return false
		end
	end
	return false
end

if not connect() then
	print("No modem found")
	print("Shutting down")
	os.shutdown()
end

while true do
	clear()
	print("Welcome to a USERS PC : Roaming Profile Enabled")
	local usr = {}
	write("Username: ")
	usr.username = read()
	write("Password: ")
	usr.password = read("*")
	if validateUsr(usr, 5) then
		clear()
		print("Welcome ", usr.username)
		break
	end
end

I didn't test them, so let me know if they work.

Edit: made some changes to the client

local users = { ["user1"] = "password1", ["user2"] = "password2" }

local users = { user1 = "password1", user2 = "password2" }

MysticT, on 23 September 2012 - 08:59 PM said:

Change the first line to:

local users = { ["user1"] = "password1", ["user2"] = "password2" }

or

local users = { user1 = "password1", user2 = "password2" }

MysticT, on 23 September 2012 - 09:09 PM said:

Did you copy the exact same code?

MysticT, on 23 September 2012 - 09:09 PM said:

Did you copy the exact same code?

if rs.testBundledInput("side", colors.blue) then
  -- do something here
end