[Lua][Error] shell.run() doesn't work

function run(path) --path must be a dir
if fs.isDir(path) then
  if fs.exists(path.."/info.ini") then
   hRead = fs.open(path.."/info.ini", "r")
   if hRead.readLine() == "icon = {" then
	icon = {}
	for i = 1, 4, 1 do
	 local a = hRead.readLine()
	 table.insert(icon, a)
	end
	local b = hRead.readLine()
	if string.sub(b, 1, 7) == "name = " then
	 name = string.sub(b, 8)
	else
	 name = fs.getName(path)
	end
	local c = hRead.readLine()
	if string.sub(c, 1, 9) == "author = " then
	 author = string.sub(c, 10)
	else
	 author = "Please write an author in info.ini"
	end
   end
   hRead.close()
  end
  gui.splash(icon, name, author)
  shell.run(path.."/"..fs.getName(path)) --Here is the error
end
end

Doyle3694, on 22 October 2012 - 07:00 PM said:

Please post your whole code

Lyqyd, on 22 October 2012 - 09:07 PM said:

Then what is it, Cloudy? http://computercraft.info/wiki/index.php?title=Fs_(API)

Try using fs.combine rather than manually concatenating the string. Also, check the final string using a print() before trying to shell.run it.

PixelToast, on 22 October 2012 - 07:13 PM said:

post the WHOLE code

Lyqyd, on 22 October 2012 - 09:07 PM said:

Then what is it, Cloudy? http://computercraft.info/wiki/index.php?title=Fs_(API) Try using fs.combine rather than manually concatenating the string. Also, check the final string using a print() before trying to shell.run it.

ChunLing, on 22 October 2012 - 09:33 PM said:

You're doubling the last component of your path, and there isn't a file by that name. Check using fs.exists on that string you made.

local programPath = fs.combine(path, fs.getName(path)..".lua")
if fs.exits(programPath) then
shell.run(programPath)
else
gui.dialogBox("Error","File doesn't exits.",{"  OK"})
end

ChunLing, on 22 October 2012 - 09:49 PM said:

"fs.exits(programPath)" ~= "fs.exists(programPath)"

Cloudy, on 22 October 2012 - 07:41 PM said:

fs.getName() isn't a function.

Cloudy, on 22 October 2012 - 10:52 PM said:

Cloudy, on 22 October 2012 - 07:41 PM said:

fs.getName() isn't a function.

ChunLing, on 23 October 2012 - 12:54 AM said:

No, it's a function, and it works, but it doesn't maybe do what it's being used for here. fs.getName() just returns the last part of a string representing a path. The path doesn't have to be real or anything.

ChunLing, on 23 October 2012 - 12:57 AM said:

And blarg, I just thought of something. You can't run shell.run on a path unless the path starts with "/". shell.run("ProgramFiles/TestProgram/TestProgram") should be shell.run("/ProgramFiles/TestProgram/TestProgram"). I ran into this ages ago and completely forget it because it's so minor.

Lyqyd, on 23 October 2012 - 07:53 PM said:

No, the shell "API" doesn't load until after the actual APIs, so you would need to manually load your API file with os.loadAPI() in the startup if you absolutely must use shell.run. os.run() may work instead.

faubiguy, on 23 October 2012 - 08:08 PM said:

The problem is that os.loadAPI doesn't add the shell API to the environment that APIs are loaded in (the shell API isn't defined at the time os.loadAPI is). shell.run adds the shell API to the environment of any program that it runs, so programs run from the shell, or run by another program using shell.run, will have access to the shell API. APIs loaded with os.loadAPI, and programs run with os.run won't (You can specifically add the shell API to the environment of programs run with os.run, but it doesn't do it automatically, unlike shell.run)

EDIT: As a workaround, you can do _G.shell = shell before loading the API. This will add shell to the global environment, which the API environments inherit from.