[lua]if state problem

my friend is trying to make a simple pokemon battle but for some reason is there a problem at line 63. even when M0000 is set to "-" at the begin of the script does the if state disagree. any idea whats wrong?

the script:

M0000 = "-"
M0001 = "Tackle"
M0002 = "Tail Whip"
M0003 = "Growl"
function yN()
  selection=1
	while true do
	  term.clear()
	  term.setCursorPos(1,1)
	  local x, y=term.getCursorPos()
	  term.clearLine()
	  if selection==1
		then write(">Attack< Exit ")
		else write (" Attack >Exit<") end
	  term.setCursorPos(x, y)
	  a, b=os.pullEvent()
	  while a~="key"
	  do a, b=os.pullEvent() end
	if b==203 and selection==2 then selection=1 end
	if b==205 and selection==1 then selection=2 end
	if b==28 then print ("") break end
	end
  if selection==1 then return true end
  if selection==2 then return false end
  return false
end
function atk(m)
  attack=1
  l=#m
  while true do
	term.clear()
	term.setCursorPos(1,1)
	print("Select your move:")
	for i=1, l, 1 do
	  if i==attack then print("["..m[i].."]") else print(" ", m[i]) end
	  end
	a, b= os.pullEventRaw()
	if a== "key" then
	if b==200 and attack>1 then attack=attack-1 end
	if b==208 and attack<l then attack=attack+1 end
	if b==28 then break end
	end
  end
  term.clear()
  term.setCursorPos(1,1)
  return attack
end

while yN() == true do
  if selection == 1 then
	local moves={
	M0001,
	M0002,
	M0003,
	M0000,
	"Back"
	}
	local attack=atk(moves)
	if attack == 5 then
	if M0000 == "-" then
	  print("No Attack!")
	  sleep(1)
	  end
	else
	  print(attack)
	  sleep(1)
	end
  else
	if selection == 2 then
	  break
	end
  end
end

Guys, dont worry.
He did not steal this.
I'm his friend FYI

I don't see the problem. I just tried the code and everything seemed to work fine. Can you explain the error in detail?

the goal is to make the script display "no attack" when the player selects the empty attack (-) but instead it just shows ''4''.

Replace

  if selection==1 then return true end
  if selection==2 then return false end

by

  if selection==1 then
   return true
  end
  if selection==2 then
   return false
  end

It's work?

Matt21, on 12 November 2012 - 05:50 AM said:

Replace

  if selection==1 then return true end
  if selection==2 then return false end

by

  if selection==1 then
   return true
  end
  if selection==2 then
   return false
  end

It's work?

Thats the same…

Edit: Nevermind, I was wrong :unsure:/>/>

Edit #2: Try make

a, b= os.pullEventRaw()

into

a, b = os.pullEvent() -- using raw will prevent os.pullEvent to not function at all (I think...)

Check out your if placement and ordering. Try selecting "Back" and see what it says. You've just got your code in an order that it's doing things you don't expect it to. Specifically, check out the if attack == 5 then just before your M0000 comparison.

minecrash, on 12 November 2012 - 05:35 AM said:

the goal is to make the script display "no attack" when the player selects the empty attack (-) but instead it just shows ''4''.

That's because you only print "No Attack!" when attack == 5, but the "-" option is attack == 4.

EDIT: Whoops, ninja'd before refresh. :unsure:/>/>

I have fixed that. My friend made a mistake with that.
Now, the change to pullEventRaw to pullEvent didn't work.

RIght know it is this:

Spoiler

M0000 = "-"
M0001 = "Tackle"
M0002 = "Tail Whip"
M0003 = "Growl"

function yN()
  selection=1
	while true do
	  term.clear()
	  term.setCursorPos(1,1)
	  local x, y=term.getCursorPos()
	  term.clearLine()
	  if selection==1
		then write(">Attack< Exit ")
		else write (" Attack >Exit<") end
	  term.setCursorPos(x, y)
	  a, b=os.pullEvent()
	  while a~="key"
	  do a, b=os.pullEvent() end
	if b==203 and selection==2 then selection=1 end
	if b==205 and selection==1 then selection=2 end
	if b==28 then print ("") break end
	end
  if selection==1 then return true end
  if selection==2 then return false end
  return false
end

function atk(m)
  attack=1
  l=#m
  while true do
	term.clear()
	term.setCursorPos(1,1)
	print("Select your move:")
	for i=1, l, 1 do
	  if i==attack then print("["..m[i].."]") else print(" ", m[i]) end
	  end
	a, b= os.pullEvent()
	if a== "key" then
	if b==200 and attack>1 then attack=attack-1 end
	if b==208 and attack<l then attack=attack+1 end
	if b==28 then break end
	end
  end
  term.clear()
  term.setCursorPos(1,1)
  return attack
end


while yN() == true do
  if selection == 1 then
	local moves={
	M0001,
	M0002,
	M0003,
	M0000,
	"Back"
	}
	local attack=atk(moves)
	if attack == 4 then
	if M0000 == "-" then
	  print("No Attack!")
	  sleep(1)
	  end
	elseif attack == 5 then
	else
	  print(attack)
	  sleep(1)
	end
  else
	if selection == 2 then
	break
	end
  end
end

It is now set to if attack == 4 then but that takes over if M0000 == "-" then.
If I removed the first one. It gives this error:
bios:338: [string "pbsselect"]:72: 'end' expected (to close 'while' at line 52)

Let's say that is fixed. What after that?

Edit: If I put another end at Line 72 (and put the current line 72 to 73) I get:
bios:338: [string "pbsselect"]:73: '<eof>' expected

Edit2: The problem is, we think that a table doesn't accept strings when asked for a statement. I might be wrong (and I probably am) but we tried a lot, and we broke and fixed it a lot. But everytime it just says 4 instead of No Attack! It needs to know that M0000 is not a move. As it needs to be used alot.

Where you have

        if M0000 == "-" then
          print("No Attack!")
          sleep(1)
          end

Do this to check if it prints "Failed" .. maybe the comparison is failing somehow?

if M0000 == "-" then
  print("No Attack!")
  sleep(1)
else
  print("Failed")
  sleep(10)
end

I cleaned up the code a little bit. Give this a try:

M0000 = "-"
M0001 = "Tackle"
M0002 = "Tail Whip"
M0003 = "Growl"

function yN()
  selection=1
        while true do
            term.clear()
            term.setCursorPos(1,1)
            local x, y=term.getCursorPos()
            term.clearLine()
            if selection==1    then
                write(">Attack< Exit ")
            else
                write(" Attack >Exit<")
            end
            term.setCursorPos(x, y)
            a, b=os.pullEvent("key") --fixed odd loop filtering; only pulls key events now.
            if b==203 and selection==2 then --fixed casing to use elseif
                selection=1
            elseif b==205 and selection==1 then
                selection=2
            elseif b==28 then
                print("")
                break
            end
	    end
    if selection==1 then --fixed casing to use elseif
        return true
    elseif selection==2 then
        return false
    end
    return false
end

function atk(m)
    attack=1
    l=#m
    while true do
        term.clear()
        term.setCursorPos(1,1)
        print("Select your move:")
        for i=1, l, 1 do
            if i==attack then print("["..m[i].."]") else print(" ", m[i]) end
        end
        a, b= os.pullEvent("key") --fixed event filtering.
        if b==200 and attack>1 then --fixed casing to use elseif
            attack=attack-1
        elseif b==208 and attack<l then
            attack=attack+1
        elseif b==28 then
            break
        end
    end
    term.clear()
    term.setCursorPos(1,1)
    return attack
end


while yN() == true do
    if selection == 1 then
        local moves={
        M0001,
        M0002,
        M0003,
        M0000,
        "Back",
        }
        local attack=atk(moves)
        if moves[attack] == "-" then --fixed attack check to index table, rather than rely on only fourth slot being a non-attack.
            print("No Attack!")
            sleep(1)
        elseif attack == 5 then
        else
            print(attack)
            sleep(1)
        end
    elseif selection == 2 then
        break
    end
end

Can you please state the changes you made?
I'd like to know that's changed for further errors

Edited code to add comments.

Lyqyd, on 12 November 2012 - 08:30 AM said:

Edited code to add comments.

Thanks.
I assume this works?
I'm gonna try this tomorrow.

I'm gonna report if it works or not but I will already thank you for fixing the code.
Unless Minecrash tests and reports, I do tomorrow.

Edit: no posts until report please!

I didn't personally test the code, but I don't think I would have broken anything by rearranging things like I did. It should also fix the "No Attack!" not showing up bug.

Lyqyd, on 12 November 2012 - 09:19 AM said:

I didn't personally test the code, but I don't think I would have broken anything by rearranging things like I did. It should also fix the "No Attack!" not showing up bug.

Well, it worked perfectly as it should be!
Thanks alot.