What is wrong with this code?

I have looked over it a TON and i don't see why it isn't working, its supposed to install my OS that I'm currently making. but that's not what happens. By the way the code your about to see is in disk/install.


code:

installing = 0.2
toprograms = "qxxdvX98"
variables = "GGj4taRD"
about = "JRNvCN2v"
checkVersion = "uZ2J4w7z"
edit = "P64PEtHd"
perry = "reT5iT41"
startup = "xwZ8CK0T"
local function installed()
  if fs.exists("black/variables") then
    return true
  else
    return false
  end
end
local function put(AeO,location)
  shell.run("pastebin","get",Ae0,location)
 
end
if installed() then
  print("Black OS is already installed!")
  print("if you want to update Black OS then")
  print("when this screen dissapers type in update")
elseif not installed() then
  shell.run("mkdir","Black")
  put(toprograms,"Black/toprograms")
  put(variables,"Black/variables")
  put(startup,"startup")
  put(perry,"perry")
  put(edit,"edit")
  put(about,"about")
  put(checkVersion,"checkVersion")
  if fs.exists("about") then
    print("Installation succesful =D Congrats!")
  else
    print("Installation un-succesful :(/>/>")
  end
else
  print("Installation un-succesful :(/>/>")
end
 

when I run it it just says the usage of pastebin alot then it says installation un-succesful. Please help me

It may help if you specified the problem. Are you getting an actual interpretation error, or does it appear to be a logic bug?
We can't exactly help you if you can't point us in the direction of your problem.

Grim Reaper, on 19 November 2012 - 01:28 PM said:

It may help if you specified the problem. Are you getting an actual interpretation error, or does it appear to be a logic bug?
We can't exactly help you if you can't point us in the direction of your problem.

when i run it there is no error. just a logic bug.

A couple things. The installed function can be reduced. Also, "black" should probably be capitalized.

local function installed()
  return fs.exists('Black/variables')
end

The main installing chunk, it'll never go down to the "else" at the end, because bools are only either true or false. It could be reduced:

if installed() then
  print("Black OS is already installed!")
  print("if you want to update Black OS then")
  print("when this screen dissapers type in update")
else
  shell.run("mkdir","Black")
  put(toprograms,"Black/toprograms")
  put(variables,"Black/variables")
  put(startup,"startup")
  put(perry,"perry")
  put(edit,"edit")
  put(about,"about")
  put(checkVersion,"checkVersion")
  if fs.exists("about") then
    print("Installation succesful =D Congrats!")
  else
    print("Installation un-succesful :(/>/>/>/>")
  end
end

You could also reduce this even more with tables magic, but that's not really necessary, and your logic here is pretty sound.

Last note, is http enabled?

Kingdaro, on 19 November 2012 - 01:39 PM said:

A couple things. The installed function can be reduced. Also, "black" should probably be capitalized.

local function installed()
  return fs.exists('Black/variables')
end

The main installing chunk, it'll never go down to the "else" at the end, because bools are only either true or false. It could be reduced:

if installed() then
  print("Black OS is already installed!")
  print("if you want to update Black OS then")
  print("when this screen dissapers type in update")
else
  shell.run("mkdir","Black")
  put(toprograms,"Black/toprograms")
  put(variables,"Black/variables")
  put(startup,"startup")
  put(perry,"perry")
  put(edit,"edit")
  put(about,"about")
  put(checkVersion,"checkVersion")
  if fs.exists("about") then
	print("Installation succesful =D Congrats!")
  else
	print("Installation un-succesful :(/>/>/>/>/>")
  end
end

You could also reduce this even more with tables magic, but that's not really necessary, and your logic here is pretty sound.

Last note, is http enabled?

yes

What exactly isn't happening properly?

Grim Reaper, on 19 November 2012 - 01:45 PM said:

What exactly isn't happening properly?

When i type in list on the computer After the installation nothing new is there accept for Black the directory, and nothing is in that.

Kingdaro, on 19 November 2012 - 01:39 PM said:

A couple things. The installed function can be reduced. Also, "black" should probably be capitalized.

local function installed()
  return fs.exists('Black/variables')
end

The main installing chunk, it'll never go down to the "else" at the end, because bools are only either true or false. It could be reduced:

if installed() then
  print("Black OS is already installed!")
  print("if you want to update Black OS then")
  print("when this screen dissapers type in update")
else
  shell.run("mkdir","Black")
  put(toprograms,"Black/toprograms")
  put(variables,"Black/variables")
  put(startup,"startup")
  put(perry,"perry")
  put(edit,"edit")
  put(about,"about")
  put(checkVersion,"checkVersion")
  if fs.exists("about") then
	print("Installation succesful =D Congrats!")
  else
	print("Installation un-succesful :(/>/>/>/>/>")
  end
end

You could also reduce this even more with tables magic, but that's not really necessary, and your logic here is pretty sound.

Last note, is http enabled?

I tried that and it doesnt work either

Grim Reaper, on 19 November 2012 - 01:45 PM said:

What exactly isn't happening properly?

My guess is that his files aren't being downloaded. Either that, or they are being downloaded, and the program is saying they aren't.

walia6, do a ls on the command line and see what's there.

Ninja'd yet again.

Kingdaro, on 19 November 2012 - 01:51 PM said:

Grim Reaper, on 19 November 2012 - 01:45 PM said:

What exactly isn't happening properly?

My guess is that his files aren't being downloaded. Either that, or they are being downloaded, and the program is saying they aren't.

walia6, do a ls on the command line and see what's there.

Ninja'd yet again.

What does Ninja'd yet again mean?

No idea. But what appears to be the problem, walia6?

Just test it out for yourself YOU WILL SEE. Ive answered that once before

Grim Reaper, on 19 November 2012 - 01:55 PM said:

No idea. But what appears to be the problem, walia6?

It is not installing my os!

That sure is helpful. Which of the files is not being downloaded properly?

Grim Reaper, on 19 November 2012 - 02:02 PM said:

That sure is helpful. Which of the files is not being downloaded properly?

ALL of them are not downloading properly

Perhaps, instead of using a shell.run on pastebin, you should probably do an http.request on your files and write them manually. Here's a rewritten "put" function.

function put(AeO, location)
  http.request('http://pastebin.com/raw.php?i='..AeO)

  while true do
    local ev, url, source = os.pullEvent()

    if ev == 'http_success' then
      local file = fs.open(location, 'w')
      file.write(source.readAll())
      file.close()
      source.close()

      print('Downloaded '..location)
      break
    elseif ev == 'http_failure' then
      print('Failure to download '..location)
      break
    end
  end
end

Kingdaro, on 19 November 2012 - 02:11 PM said:

Perhaps, instead of using a shell.run on pastebin, you should probably do an http.request on your files and write them manually. Here's a rewritten "put" function.

function put(AeO, location)
  http.request('http://pastebin.com/raw.php?i='..AeO)

  while true do
	local ev, url, source = os.pullEvent()

	if ev == 'http_success' then
	  local file = fs.open(location, 'w')
	  file.write(source.readAll())
	  file.close()
	  source.close()

	  print('Downloaded '..location)
	  break
	elseif ev == 'http_failure' then
	  print('Failure to download '..location)
	  break
	end
  end
end

You are Awesome. I'll make sure to credit you for the installation on the fourms when im done making it in a few minutes

Have you tested it first? I want to make sure I'm not credited for a broken function :(/>/>

Kingdaro, on 19 November 2012 - 03:03 PM said:

Have you tested it first? I want to make sure I'm not credited for a broken function :(/>/>

Works! the topic is here :(/>/>