[Question] whats wrong with this code

local engines = false

print("engines on or off?")
question == io.read()
while true do
if question == on then
engines = true
term.clear()
break
else
if question == off then
engines = false
term.clear()
break
else
print("You need to say ON or OFF!")
end
end
end

edit: this is the error:
bios:388: [string "engines"] :4: '=' expected

Well first off all print Your error,
And You need to call on and off as strings like this:

"on"
"off"

Please don't double post, it won't get you help any quicker… I have answered your question in the other topic you posted it…

Also this IS the correct place to post issues like this… not in "Programs" that area is for completed code…

TheOriginalBIT, on 20 January 2013 - 12:35 PM said:

Please don't double post, it won't get you help any quicker… I have answered your question in the other topic you posted it…

Also this IS the correct place to post issues like this… not in "Programs" that area is for completed code…

You mean that he posted like the exactly same thing before?

Hellkid98, on 20 January 2013 - 01:15 PM said:

TheOriginalBIT, on 20 January 2013 - 12:35 PM said:

Please don't double post, it won't get you help any quicker… I have answered your question in the other topic you posted it…

Also this IS the correct place to post issues like this… not in "Programs" that area is for completed code…

You mean that he posted like the exactly same thing before?

He posted it here http://www.computercraft.info/forums2/index.php?/topic/9533-what-is-wrong-need-help/

Generally, you want to tell us what is wrong with the code…what happens when you run it that differs from what you thought would happen (often this include the issuance of an error message).

We then are able to tell you why it is wrong, and perhaps how to fix it to do what you want.

In this case, with the information given, I'm going to say that there is nothing wrong with this code :)/>

this is the error:
bios:388: [string "engines"] :4: '=' expected

You set a variable with = and compare to values with ==.
Line 4 should be question = io.read()

sjele, on 20 January 2013 - 11:45 PM said:

You set a variable with = and compare to values with ==.
Line 4 should be question = io.read()

ooh jeah i am stupid that i dont saw that thank you very much :)/>

sjele, on 20 January 2013 - 11:45 PM said:

Line 4 should be question = io.read()

Doesn't need to be… read() does the same…

TheOriginalBIT, on 21 January 2013 - 12:01 PM said:

sjele, on 20 January 2013 - 11:45 PM said:

Line 4 should be question = io.read()

Doesn't need to be… read() does the same…

Yeah but he has question == io.read()

Of course, we're moving towards the much worse behavior of continuously printing "You need to say ON or OFF!" until the computer is stopped for failure to yield.

But hey, maybe that's intentional? ;)/>

ChunLing, on 21 January 2013 - 10:07 PM said:

Of course, we're moving towards the much worse behavior of continuously printing "You need to say ON or OFF!" until the computer is stopped for failure to yield.

But hey, maybe that's intentional? ;)/>

Haha, only saw that now. It's hard to see if you're not really concentrating because of no code tags or indentation :P/>